Conversation
| @Override | ||
| public String getSince() { | ||
| return "2.426.1"; | ||
| return "2.558"; |
There was a problem hiding this comment.
Noting this doesn't exist yet.
Not sure if this is misleading or not as dialogs have been around for awhile but the first technique is new.
Shouldn't this PR also document wizards as those PRs are introducing the feature? WDYT?
There was a problem hiding this comment.
Not sure if this is misleading or not as dialogs have been around for awhile but the first technique is new.
A little misleading but dialogs haven't been implemented that much by plugins anyway, I think there'll be a big push for them once the experimental flags are on by default.
Shouldn't this PR also document wizards as those PRs are introducing the feature? WDYT?
Once they're used in core for sure.
| </div> | ||
|
|
||
| <s:section title="Customizing the appearance and behaviour"> | ||
| <s:section title="${%Customizing the appearance and behaviour}"> |
There was a problem hiding this comment.
There's also preventCloseOnOutsideClick could be a good time to document it?
|
Converted to draft until core change is merged to prevent accidental merging |
| <jenkins.baseline>2.479</jenkins.baseline> | ||
| <jenkins.version>2.541</jenkins.version> | ||
| <jenkins.baseline>2.528</jenkins.baseline> | ||
| <jenkins.version>2.557-rc38119.74eb_a_b_c6c579</jenkins.version> |
| <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ --> | ||
| <jenkins.baseline>2.479</jenkins.baseline> | ||
| <jenkins.version>2.541</jenkins.version> | ||
| <jenkins.baseline>2.528</jenkins.baseline> |
There was a problem hiding this comment.
should use the latest baseline:
| <jenkins.baseline>2.528</jenkins.baseline> | |
| <jenkins.baseline>2.541</jenkins.baseline> |
2 participants
Relates to jenkinsci/jenkins#26475 and jenkinsci/jenkins#26514
This PR updates the Dialogs page in the Design Library. The intention is to push developers to using the new
data-type="dialog-opener"approach to dialogs, this has several advantages:I've removed the mentions of prompts and modals. Done some generic tidying up and added a fade to the code component.
GitHub has butchered the below image, click it to see it in the right aspect ratio.
Testing done
N/A.
Submitter checklist