Skip to content

fix(windows): enable HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem\LongPathsEnabled #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lemeurherveCB wants to merge 40 commits into from
Closed

fix(windows): enable HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem\LongPathsEnabled #949

lemeurherveCB wants to merge 40 commits into from

Conversation

@lemeurherveCB
Copy link
Contributor

@lemeurherveCB lemeurherveCB commented Mar 4, 2025 •
edited
Loading

This PR enables HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem\LongPathsEnabled to avoid errors encountered on too long filenames.

Ref:

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

jglick
jglick approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

jtnord
jtnord reviewed Mar 4, 2025
View reviewed changes
lemeurherveCB
lemeurherveCB commented Mar 4, 2025
View reviewed changes
smerle33
smerle33 reviewed Mar 5, 2025
View reviewed changes
@lemeurherveCB lemeurherveCB mentioned this pull request Mar 5, 2025
Closed
lemeurherveCB and others added 18 commits March 5, 2025 11:01
@lemeurherveCB
TODO to be removed
57e1456
@lemeurherveCB
git init/fetch/checkout instead of git clone (which fails in long paths)
520edc4
@lemeurherveCB
no ||
2584722
@lemeurherveCB
add TODO
bd59564
@lemeurherveCB
missing git init
13f4c98
@lemeurherveCB
sanity checks
4fd8d3c
@lemeurherveCB
also return git version
278bba9
@lemeurherveCB
short repo folder name
8bc8f79
@lemeurherveCB
try hardcoded path like the one from https://github.com/jenkins-infra…
f192d43 
…/helpdesk/issues/4574\#issuecomment-2700419033
@lemeurherveCB
Merge branch 'master' into helpdesk4574-enable-long-paths-on-windows
b91dc1d
@lemeurherveCB
comment all other tests for now
863a921
@lemeurherveCB
only jdk21 for now
256c5ac
@lemeurherveCB
only nanoserver-ltsc2019 & windowsservercore-ltsc2022 for now
75e01a5
@lemeurherveCB
fixup! only nanoserver-ltsc2019 & windowsservercore-ltsc2022 for now
fee2c84
@lemeurherveCB
fixup! only nanoserver-ltsc2019 & windowsservercore-ltsc2022 for now
cfc2889
@lemeurherveCB
Revert "fixup! only nanoserver-ltsc2019 & windowsservercore-ltsc2022 …
4137a60 
…for now"

This reverts commit cfc2889.
@lemeurherveCB
Revert "fixup! only nanoserver-ltsc2019 & windowsservercore-ltsc2022 …
330f2a5 
…for now"

This reverts commit fee2c84.
@lemeurherveCB
exit 0 build.sh, no linux for now
84ce7a9
@dduportal dduportal mentioned this pull request Mar 11, 2025
Closed
@lemeurherveCB
Copy link
Contributor Author

lemeurherveCB commented Mar 30, 2025

Closing, will open a fresh PR.

@lemeurherveCB lemeurherveCB deleted the helpdesk4574-enable-long-paths-on-windows branch March 30, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jtnord jtnord jtnord left review comments

@smerle33 smerle33 smerle33 left review comments

@jglick jglick jglick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lemeurherveCB @jglick @jtnord @smerle33