chore(windows): use docker bake to generate the docker compose file

[lemeurherve]

This change aligns this repository with https://github.com/jenkinsci/docker-agents and https://github.com/jenkinsci/docker-ssh-agent by transplanting the mechanism allowing to use docker bake to generate the docker compose file used to build Windows images until docker buildx is able to build Windows images.

The main advantage is to get a single place of truth where all images and parameters are defined (the docker bake file), facilitating the maintainance of this repository.

The second potential advantage is the possibility to use this PR to easily ship both Windows 2019 and 2022 images in LTS 2.541.1 release, to be discussed. (cf #2167 (comment))

It also allow a possible differenciation between versions provided in Weekly or LTS releases to ease transitions (cf #2197 (comment)).

Finally, it should reduce maintainance effort for these Windows controller images cf #2197 (comment), and to unlock potential improvements and cleanups.

Similar to:

• chore: use docker bake to generate docker compose file docker-ssh-agent#415
• chore: align with docker-ssh-agent build process docker-agents#827

Refs:

• Use only docker-bake.hcl for both Linux and Windows image definitions docker-ssh-agent#426
• provide jdk25 variants #2121 (comment)
• Provide Windows Server 2022 image #2167 (comment)

Testing done

Locally

$ make list-linux
+ make --silent show-linux
+ jq -r '.target | keys[]'
+ docker buildx bake -f docker-bake.hcl --load --progress=quiet linux --print
+ jq
alpine_jdk21
alpine_jdk25
debian-slim_jdk21
debian-slim_jdk25
debian_jdk21
debian_jdk25
rhel_jdk21
rhel_jdk25

$ make list
+ make --silent listarch-arm64
+ make --silent showarch-arm64
+ jq -r '.target | keys[]'
+ make --silent show
+ jq --arg arch linux/arm64 '.target |= with_entries(select(.value.platforms | index($arch)))'
+ make --silent show-all
+ docker buildx bake -f docker-bake.hcl --load --progress=quiet all --print
+ jq
alpine_jdk21
alpine_jdk25
debian-slim_jdk21
debian-slim_jdk25
debian_jdk21
debian_jdk25
rhel_jdk21
rhel_jdk25

$ OS=windows ARCH=amd64 make list
+ make --silent listarch-amd64
+ make --silent showarch-amd64
+ jq -r '.target | keys[]'
+ make --silent show
+ jq --arg arch windows/amd64 '.target |= with_entries(select(.value.platforms | index($arch)))'
+ make --silent show-all
+ docker buildx bake -f docker-bake.hcl --load --progress=quiet all --print
+ jq
windowsservercore-ltsc2022_jdk21
windowsservercore-ltsc2022_jdk25

ci.jenkins.io

https://ci.jenkins.io/job/Packaging/job/docker/job/PR-2189

trusted.ci.jenkins.io

Tested the calls to ./make.ps1 build and ./make.ps1 test in an trusted.ci.jenkins.io infra check job replay from this PR branch, using the same windows-2019 and windows-2022 and the same PowerShell version used by the Windows parts of this pipeline: https://trusted.ci.jenkins.io/job/Infra-Team-Validate-Agents/597

Test pipeline

#!/usr/bin/env groovy

// Pair of agent template labels to use, and target(s) to test from each of these templates
// Labels & targets requested from https://github.com/jenkinsci/docker/Jenkinsfile
def ProcessorsLabelsAndDockerBakeTargets = [
    // Main test: Windows images
    'windows-2019': ['windowsservercore-ltsc2019'],
    'windows-2022': ['windowsservercore-ltsc2022'],
    // Sanity checks: commons linux targets and arm64 one
    'docker && amd64': ['alpine_jdk21', 'debian_jdk25'],
    'arm64docker': ['arm64'],
]

// Generate a parallel step for each label in labels
def generateParallelSteps(processors) {
    def parallelNodes = [:]
    processors.each { unboundLabel, unboundTargetList ->
        // Bind before the closure
        def label = unboundLabel
        def targetList = unboundTargetList
        targetList.each { unboundTarget ->
            def target = unboundTarget
            def combination = "$target on $label"
            parallelNodes[combination] = {
                node(label) {
                    timestamps {
                        withEnv([
                            // Branch of https://github.com/jenkinsci/docker/pull/2189
                            "REVISION=windows-use-docker-bake_2026-01-08",
                            "IMAGE_TYPE=$target",
                            "GITHUB_OWNER=lemeurherve",
                        ]) {
                            stage('Get docker and CPU info') {
                                if (isUnix()) {
                                    sh 'docker info'
                                    sh 'cat /proc/cpuinfo'
                                } else {
                                    powershell 'docker info'
                                    powershell 'Get-CimInstance Win32_Processor | Out-String'
                                    powershell 'Get-ComputerInfo | Out-String'
                                }
                            }
                            stage("Retrieve jenkinsci/docker at a specific revision") {
                                if (isUnix()) {
                                    sh '''
                                        git clone https://github.com/${GITHUB_OWNER}/docker
                                        cd docker
                                        git checkout "${REVISION}"
                                        git log -1 -p
                                    '''
                                } else {
                                    powershell '''
                                        git clone https://github.com/${env:GITHUB_OWNER}/docker
                                        cd docker
                                        git checkout "${env:REVISION}"
                                        git log -1 -p
                                    '''
                                }
                            }
                            // Using the same `make` and `make.ps1` calls than in jenkinsci/docker
                            stage("Build docker bake target") {
                                dir('docker') {
                                    if (isUnix()) {
                                        sh '''
                                            # Fallback to buildarch-% in case the target is an "architecture" one
                                            make "build-${IMAGE_TYPE}" || make "buildarch-${IMAGE_TYPE}"
                                        '''
                                    } else {
                                        powershell '''
                                            ./make.ps1 build -ImageType ${env:IMAGE_TYPE}
                                        '''
                                    }
                                }
                            }
                            stage("Test docker bake target") {
                                dir('docker') {
                                    if (isUnix()) {
                                        sh '''
                                            # no "testarch-%" target, arch builds not tested in the repo pipeline anyway
                                            make "test-${IMAGE_TYPE}" || true
                                        '''
                                    } else {
                                        powershell '''
                                            ./make.ps1 test -ImageType ${env:IMAGE_TYPE} -TestsDebug verbose
                                        '''
                                    }
                                }
                            }
                        }
                    }
                }
            }
        }
    }  
    return parallelNodes
}

timeout(unit: 'MINUTES', time: 60) {
    stage('Processor') {
        parallel generateParallelSteps(ProcessorsLabelsAndDockerBakeTargets)
    }
}

Build of multiple Windows versions

See #2189 (comment)

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[dduportal]

If it works on trusted.ci, LGTM

[lemeurherve]

Putting in draft until a proper test via a simulated build in a new job on trusted.ci.jenkins.io next Monday.