Skip to content

draft POC used to validate a hunch (do not merge) #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikecirioli
Copy link

@mikecirioli mikecirioli commented May 9, 2025

After investigating an issue where jobs on windows agents can hang indefinitely it seems the root cause of the job not being terminated is because there is no implementation of exitStatus for the WindowsBatchScript and PowershellScript classes (see this implementation in BourneshellScript)

My understanding is that the controller should be checking for an updated heartbeat which is written by the durable-task-lib binary wrapper. If it detects that this heartbeat is not being updated then the job should be terminated.

I did a quick and dirty test to see if this theory is correct (#263 ) and it appears to support the findings. (this PR is not mean to be a ready solution!). I noticed that even though it seems like the heartbeat check should occur every 30 seconds, it was only occuring 30 seconds after the agent is first brought back online. If you repeat this process twice (needed because the first time is the initial check and does not really count) you will see that the job will then exit correctly. I expected that this check should occur even if the agent is not back online, so there are likely issues with my test PR or my understanding of how things work - this behavior should be confirmed as part of the bug fix

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@car-roll car-roll changed the title [SECO-4498] draft POC used to validate a hunch draft POC used to validate a hunch May 9, 2025
@mikecirioli mikecirioli changed the title draft POC used to validate a hunch draft POC used to validate a hunch (do not merge) May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant