fix WinRM thread leak #1987
Merged
fix WinRM thread leak #1987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apuig
commented
Dec 10, 2025
Contributor
Author
There was a problem hiding this comment.
mkdirProcess and initProcess errors did not appear in the logs, but for completeness, I am also proposing to handle them.
Member
jglick
approved these changes
Dec 15, 2025
Comment on lines
+93
to
+99
| LOGGER.log(Level.FINE, () -> "Failed to signal WinRM shell: " + e.getMessage()); | ||
| } | ||
|
|
||
| try { | ||
| client.deleteShell(); | ||
| } catch (Exception e) { | ||
| LOGGER.log(Level.FINE, () -> "Failed to delete WinRM shell: " + e.getMessage()); |
Member
There was a problem hiding this comment.
Why FINE and not WARNING? We do not expect exceptions here do we?
Contributor
Author
There was a problem hiding this comment.
From what I can tell, it’s possible to call destroy on a Terminated instance. In this case, WinRM operations are expected to fail.
I’ll look into whether there’s a straightforward way to detect this status so we can adjust the log level accordingly.
Member
There was a problem hiding this comment.
In this case, WinRM operations are expected to fail.
A comment to that effect would suffice I think.
res0nance
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1986
Testing done
I was unable to create tests that aren’t almost entirely reliant on mocks. I plan to test this fix using real infrastructure instead. Any advice or suggestions would be greatly appreciated.
Submitter checklist