Fix references to RealJenkinsRule.JenkinsStartupException#36
Merged
jtnord merged 4 commits intojenkinsci:masterfrom Jan 7, 2026
Merged
Fix references to RealJenkinsRule.JenkinsStartupException#36jtnord merged 4 commits intojenkinsci:masterfrom
jtnord merged 4 commits intojenkinsci:masterfrom
Conversation
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
jglick
reviewed
Jan 2, 2026
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Contributor
Author
Addressed in ebd5ab3 |
jglick
approved these changes
Jan 2, 2026
| public void testStartupFips() throws Throwable { | ||
| rjr.javaOptions("-Xmx128M", "-Djenkins.security.FIPS140.COMPLIANCE=true"); | ||
| JenkinsStartupException jse = assertThrows(JenkinsStartupException.class, () -> { | ||
| IOException jse = assertThrows(IOException.class, () -> { |
Member
There was a problem hiding this comment.
Fine, or just do not assert the exception type at all.
| IOException jse = assertThrows(IOException.class, () -> { | ||
| rjr.then(r -> { | ||
| Jenkins.get().getPluginManager().uberClassLoader.loadClass("net.i2p.crypto.eddsa.EdDSAEngine"); | ||
| fail("should not get here!"); |
Member
There was a problem hiding this comment.
BTW this is redundant. I think the whole assertion could be something like
assertThat(assertThrows(Throwable.class, () -> rjr.run(r -> r.jenkins.pluginManager.uberClassLoader.loadClass("net.i2p.crypto.eddsa.EdDSAEngine"))).getMessage(),
containsString(
"The eddsa-api plugin is not FIPS compliant and can not be used in a Jenkins configured to run in FIPS-140 mode"));
Member
|
Maintainers please remember to apply the |
Member
|
@jtnord I believe you may have write permission here? |
jtnord
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jenkinsci/jenkins#26020 for some context and additional information
Testing done
None, rely on
ci.jenkins.ioto test it.Submitter checklist