Skip to content

Migrate tests to JUnit5#227

Merged
viceice merged 1 commit intojenkinsci:mainfrom
strangelookingnerd:migrate_to_junit5
Apr 28, 2025
Merged

Migrate tests to JUnit5#227
viceice merged 1 commit intojenkinsci:mainfrom
strangelookingnerd:migrate_to_junit5

Conversation

@strangelookingnerd
Copy link
Contributor

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Remove public visibility for test classes and methods
  • Minor clean up

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner April 24, 2025 08:46
* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup
@viceice viceice added developer 👷 Changes for plugin developers - used by Release Drafter test A PR that adds to testing - used by Release Drafter and removed developer 👷 Changes for plugin developers - used by Release Drafter labels Apr 28, 2025
@viceice viceice merged commit 1cdae35 into jenkinsci:main Apr 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test A PR that adds to testing - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants