Skip to content

Conversation

@MarkEWaite
Copy link
Contributor

[JENKINS-75556] ClassCastException connecting to Gitee server

JENKINS-75556 reports the issue. Revert this change so that Gitee users are able to install and use the most recent release of the plugin.

This reverts commit 437cb91.

Testing done

Confirmed that automated tests pass. Will request users to test the incremental build after pull request is built.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

[JENKINS-75556] ClassCastException connecting to Gitee server

https://issues.jenkins.io/browse/JENKINS-75556 reports the issue.
Revert this change so that Gitee users are able to install and use the
most recent release of the plugin.

This reverts commit 437cb91.
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Apr 23, 2025
}

public void doGenerateSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse2 response) {
public void doGenerateSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse response) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If DescriptorImpl#doGenerateSecretToken connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
}

public void doGenerateSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse2 response) {
public void doGenerateSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse response) {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning

Potential missing permission check in DescriptorImpl#doGenerateSecretToken
}

public void doClearSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse2 response) {
public void doClearSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse response) {;

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If DescriptorImpl#doClearSecretToken connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
}

public void doClearSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse2 response) {
public void doClearSecretToken(@AncestorInPath final Job<?, ?> project, StaplerResponse response) {;

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning

Potential missing permission check in DescriptorImpl#doClearSecretToken
@MarkEWaite
Copy link
Contributor Author

Closing because a fix has been proposed in

@MarkEWaite MarkEWaite closed this Apr 24, 2025
@MarkEWaite MarkEWaite deleted the fix-classCastException branch June 21, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Incorrect or flawed behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant