Skip to content

Conversation

@Puffy1215
Copy link
Contributor

@Puffy1215 Puffy1215 commented Apr 24, 2025

- Renamed private class ResteasyClientBuilder to HttpCredsResteasyClientBuilderImpl to avoid duplicate names and better reflect functionality of class
- Removed getHttpEngine as it holdover from forking from GitLab and their RESTful API version 3

From discussion on #78. Waiting on merge from #78 for fixes.

Investigating the private static class ResteasyClientBuilder inside ResteasyGiteeClientBuilder. Currently, the name matches a now abstract class from Jakarta EE 9 which is un-instantiable. Renaming to HttpCredsResteasyClientBuilderImpl is a more apt name and avoids confusion.

Removed getHttpEngine as it is a holdover from the GitLab fork for this project (17e89c3) to support GitLabs different RESTful api versions (v3 in particular), which is not applicable for Gitee.

Testing done

Tried on Linux Jenkins version 2.504 for via "Test Connection". No issues, successfully connected.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…entBuilderImpl to avoid duplicate names and better reflect functionality of class

- Removed getHttpEngine as it holdover from forking from GitLab and their RESTful API version 3
@MarkEWaite
Copy link
Contributor

Thanks so much for the pull request @Puffy1215 . Are you interested in adopting the plugin? It needs a maintainer, preferably one that is familiar with Gitee and can read and write Chinese. I'm happy to review pull requests and help with maintenance, but I am only confident in English and Italian.

@Puffy1215
Copy link
Contributor Author

Hi, yes I would love to maintain this! I have created a pull request per the guidelines: jenkins-infra/repository-permissions-updater#4408

I created a message post in the Google mailing list, but I think it needs to be approved.

@MarkEWaite
Copy link
Contributor

I created a message post in the Google mailing list, but I think it needs to be approved.

Developer list message is now visible.

@MarkEWaite MarkEWaite added the developer Affects developers and maintainers label Apr 28, 2025
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, though I'd prefer that you test it interactively as well before merging it. I've labeled it developer so that when it is merged it will generate a new release. If you would prefer to not release it immediately, you can change the label to maintenance or internal.

@MarkEWaite MarkEWaite changed the title [DRAFT] Simplify private class ResteasyClientBuilder Simplify private class ResteasyClientBuilder Apr 28, 2025
@Puffy1215 Puffy1215 merged commit e7ae26d into jenkinsci:master Apr 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Affects developers and maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants