Applied recipe ReplaceLibrariesWithApiPlugin #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
requested changes
Apr 25, 2025
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
I don't understand why those API plugin dependencies were proposed. The plugin did not previously declare a dependency on any of those API's, so there is no direct library dependency that is being replaced.
Some of the libraries are already included as transitive dependencies from other plugins, but I don't see any reason to create a direct dependency on something that the plugin does not call directly.
Can you tell me if I've misunderstood something?
Contributor
Author
|
No Mark, you're spot on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
giteedevelopers! 👋This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:
Use API plugin instead of direct dependency
io.jenkins.tools.pluginmodernizer.ReplaceLibrariesWithApiPlugin