Skip to content

Fix NPE when private key is not set (via JCasC) #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix NPE when private key is not set (via JCasC) #273

wants to merge 2 commits into from

Conversation

@ingwarsw
Copy link
Contributor

@ingwarsw ingwarsw commented Jul 13, 2021

Fixes NPE when private key is nor set via JCasC.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ingwarsw ingwarsw marked this pull request as draft July 13, 2021 10:29
@ingwarsw ingwarsw marked this pull request as ready for review July 19, 2021 14:37
@yarinkos
Copy link

yarinkos commented Jun 12, 2022

@ingwarsw - is there any pending issue to resolve with this PR ?
Just curious why some PR isn't getting merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ingwarsw @yarinkos