Skip to content

Conversation

@ViliusS
Copy link
Contributor

@ViliusS ViliusS commented Apr 9, 2023

This PR uses the same algorithm as "kubectl rollout status" for the verification of rollout deployments.

Fixes #119

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ViliusS
Copy link
Contributor Author

ViliusS commented Jun 26, 2023

@olamy ping

@ViliusS ViliusS force-pushed the improve-verify-deployments-1 branch from 695feaa to 70109be Compare June 28, 2023 11:08
@ViliusS ViliusS force-pushed the improve-verify-deployments-1 branch from 70109be to 9d124f6 Compare July 27, 2023 12:55
@ViliusS ViliusS force-pushed the improve-verify-deployments-1 branch from 9d124f6 to 4a6e3b0 Compare August 7, 2023 11:04
With the exception of progress deadline, it now uses the same algorith
as "kubectl rollout status":
https://github.com/kubernetes/kubectl/blob/f89fc21e9c51d313e923eb93d1ae83754be62019/pkg/polymorphichelpers/rollout_status.go#L80-L88

While at it, rename minimum replicas to desired replicas as per
Kubernetes terminology. Minimum replicas are more used in
Horizontal Pod Autoscaling, not the Deployment configuration.
@ViliusS ViliusS force-pushed the improve-verify-deployments-1 branch from 4a6e3b0 to 9167347 Compare May 13, 2024 08:15
@ViliusS
Copy link
Contributor Author

ViliusS commented Apr 24, 2025

@basil can this be merged? The plugin seems to be abandoned by Google, but it is still useful.

@basil
Copy link
Member

basil commented Apr 24, 2025

Hi @ViliusS, I'm not doing feature work on this plugin, but you can adopt it following the instructions at https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

@ViliusS
Copy link
Contributor Author

ViliusS commented Apr 26, 2025

@olamy @craigdbarber @stephenashank @donmccasland @batmat @raul-arabaolaza is anyone still maintaining this plugin, o was it abandoned?

@jtnord jtnord requested review from a team and Copilot June 19, 2025 11:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the verification process for rollout deployments by aligning the logic with the kubectl rollout status algorithm. Key changes include updating test assertions to reflect new replica terminology, modifying the log message to use a pre-defined message constant, and revising the deployment verification logic to compare available, updated, and desired replicas.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/test/java/com/google/jenkins/plugins/k8sengine/KubernetesVerifiersTest.java Updated test assertions and renamed variables to match the new verification logic
src/main/java/com/google/jenkins/plugins/k8sengine/VerificationTask.java Updated the log message format to use a message constant for consistency
src/main/java/com/google/jenkins/plugins/k8sengine/KubernetesVerifiers.java Revised the deployment verification logic and updated related JSON paths and constants
Comments suppressed due to low confidence (1)

src/main/java/com/google/jenkins/plugins/k8sengine/KubernetesVerifiers.java:175

  • Adding an inline comment to explain the rationale behind these specific replica comparisons (and how they mirror the kubectl rollout status behavior) would improve code clarity and maintainability.
                    && availableReplicas.intValue() == updatedReplicas.intValue();

@jtnord jtnord merged commit 126ec3e into jenkinsci:develop Jun 19, 2025
17 checks passed
@jtnord jtnord added the bug Something isn't working label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VerifyDeployments does not verify rolling updates are completed

3 participants