Skip to content

Removed 2 unnecessary stubbings in VaultBuildWrapperTest.java #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ARUS2023 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed 2 unnecessary stubbings in VaultBuildWrapperTest.java #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118f054
Removed 2 unnecessary stubbings in VaultBuildWrapperTest.java
ARUS2023 Oct 5, 2023
637d5cc
Update VaultBuildWrapperTest.java
ARUS2023 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/test/java/com/datapipe/jenkins/vault/VaultBuildWrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import java.io.PrintStream;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import jenkins.tasks.SimpleBuildWrapper;
import org.junit.Rule;
Expand Down Expand Up @@ -43,7 +42,6 @@ public void testWithNonExistingPath() throws IOException, InterruptedException {
PrintStream logger = new PrintStream(baos);
SimpleBuildWrapper.Context context = null;
Run<?, ?> build = mock(Build.class);
when(build.getParent()).thenReturn(null);
EnvVars envVars = mock(EnvVars.class);
when(envVars.expand(path)).thenReturn(path);

Expand Down Expand Up @@ -75,7 +73,6 @@ private List<VaultSecret> standardSecrets(String path) {
private LogicalResponse getNotFoundResponse() {
LogicalResponse resp = mock(LogicalResponse.class);
RestResponse rest = mock(RestResponse.class);
when(resp.getData()).thenReturn(new HashMap<>());
when(resp.getRestResponse()).thenReturn(rest);
when(rest.getStatus()).thenReturn(404);
return resp;
Expand Down