Bump vault-java-driver to 6.2.2 to fix TLS 1.3 regression#368
Merged
Conversation
vault-java-driver 6.x hard-coded SSLContext.getInstance("TLSv1.2") for
its DISABLED_SSL_CONTEXT and SslConfig build paths, capping TLS
negotiation at 1.2 and breaking connections to Vault servers that
require TLS 1.3.
6.2.2 replaces these with getInstance("TLSv1.3"). A TLSv1.3 context
still enables TLSv1.2, so it negotiates correctly with both TLS 1.2 and
TLS 1.3 servers, fixing the regression upstream without a plugin-side
workaround.
Fixes #361
jetersen
force-pushed
the
fix/tls1.3-skip-ssl-verify
branch
from
4b131f3 to
42816bd
Compare
jetersen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
vault-java-driverfrom 6.2.0 to 6.2.2.Why
vault-java-driver 6.x hard-coded
SSLContext.getInstance("TLSv1.2")for itsDISABLED_SSL_CONTEXT(Rest.java) and bothSslConfigbuild paths, capping TLS negotiation at 1.2. This broke connections to Vault servers that require TLS 1.3 (protocol_versionhandshake failure), e.g. whenskipSslVerificationis enabled or a custom CA cert is loaded.6.2.2 replaces these with
getInstance("TLSv1.3"). A TLSv1.3 context still enables TLSv1.2, so it negotiates correctly with both TLS 1.2 and TLS 1.3 servers — the regression is fixed upstream, with no plugin-side workaround needed.Fixes #361