Set agent CPU resources requests/limits to exactly .5 CPUs #1401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
512mis technically a valid quantity, it implies that the CPU is a binary-oriented resource like memory, instead of decimal-oriented.I'd consider this only a patch change, since despite it being a change to the default values, I doubt there's anyone out there strictly relying on those extra 12 milli-CPUs being available. It does potentially mean that more agents will get scheduled than before in a cluster that generally uses "round" numbers for scheduling (e.g. if a node had 1 whole CPU free, it could now schedule 2 agent pods instead of just 1), but the whole point of requests/limits is to allow kubernetes to pack in pods as effectively as possible.
What does this PR do?
If you modified files in the
./charts/jenkins/directory, please also include the following:Special notes for your reviewer