feat(jenkins): add agentInjection support to pod template#1650
Open
elkh510 wants to merge 4 commits intojenkinsci:mainfrom
Open
feat(jenkins): add agentInjection support to pod template#1650elkh510 wants to merge 4 commits intojenkinsci:mainfrom
elkh510 wants to merge 4 commits intojenkinsci:mainfrom
Conversation
Expose the agentInjection property from the Kubernetes plugin PodTemplate in the Helm chart values. This allows users to configure the 'Inject Jenkins agent in agent container' option via values.yaml instead of manually setting it in the UI. Fixes jenkinsci#1343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the
agentInjectionproperty from the Kubernetes pluginPodTemplatein the Helm chart values.This allows users to configure the "Inject Jenkins agent in agent container" option via
values.yaml:Instead of manually setting it in the Jenkins UI (Manage Jenkins → Clouds → Kubernetes → Pod Templates → default).
Changes
charts/jenkins/values.yaml: Addedagent.agentInjection(default:false)charts/jenkins/templates/_helpers.tpl: RenderagentInjectionin the pod template JCasC configMotivation
Using
agentInjectionavoids version drift between the Jenkins controller and the agent by injecting the agent into the agent container instead of using a separate jnlp sidecar. Currently this option can only be set via the UI, which is not compatible with GitOps/IaC workflows.Fixes #1343