Skip to content

Upgrade HtmlUnit from 2.x to 3.x - #589

Open
timja-bot wants to merge 3 commits into
jenkinsci:latestfrom
timja-bot:htmlunit-2.x-to-3.x
Open

Upgrade HtmlUnit from 2.x to 3.x#589
timja-bot wants to merge 3 commits into
jenkinsci:latestfrom
timja-bot:htmlunit-2.x-to-3.x

Conversation

@timja-bot

Copy link
Copy Markdown

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 5, 2023
@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 77e76a0 and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants