Skip to content

Redesign the Jenkins header#10245

Merged
krisstern merged 172 commits intojenkinsci:masterfrom
janfaracik:new-header
Apr 18, 2025
Merged

Redesign the Jenkins header#10245
krisstern merged 172 commits intojenkinsci:masterfrom
janfaracik:new-header

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented Feb 6, 2025

Hey there 👋

This PR redesigns the Jenkins header, bringing it a modern look and new functionality. This was demoed in the latest UX Sig as well as at the 2025 Jenkins Contributor Summit. The goal of this redesign is to simplify the header, whilst also introducing new functionality as well.

image image

What's new?

  • New theme, draws less attention to itself vs content on the page
  • Breadcrumb bar has been merged with the header, providing roughly 40px in extra vertical real estate, when combined with the removed margin its close to 90px extra

View comparison

  • Top level actions now show in the header
    • For example, Manage Jenkins now appears in the header by default - making it accessible on every page
    • Plugins like Design Library and the infamous Beer plugin behave the same way
    • They can also feature badges - this is currently used to highlight administrative monitors on the Manage Jenkins action
    • These actions collapse into an overflow menu when there's not enough space for them
  • The user account action now shows the users avatar
  • Breadcrumbs now collapse rather than scroll if theres too many, you'll see an overflow menu when there are too many
    * ➡️ Breadcrumbs no longer feature menus - this is something that can be restored based on user feedback in this thread, let me know if you use them and find them valuable - I personally find them rather fiddly but that could just be me
  • For header developers - the header features spots to show additional information now, so for simpler changes you'll no longer need to replace the entire header
Additional screenshots image image image image image

I've got a branch for Customizable header plugin in the works - it's quite fun:

image image image

What's left to do?

Testing done

  • Breadcrumbs work, root actions appear as expected
  • Sign in/sign out works
  • High contrast mode works
  • Breadcrumbs and actions collapse/appear on window resize
  • Works with the updated Customisable Header plugin

Proposed changelog entries

  • Redesign the Jenkins header

Developer changelog

  • Root actions can now display badges in the header, as well as a jumplist of actions by implementing jumplist.jelly

Proposed upgrade guidelines

N/A

### Submitter checklist
- [ ] The Jira issue, if it exists, is well-described.
- [x] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.
- [x] There is automated testing or an explanation as to why this change has no tests.
- [ ] New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.
- [ ] New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.
- [ ] New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).
- [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
- [ ] For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

### Maintainer checklist
- [x] There are at least two (2) approvals for the pull request and no outstanding requests for change.
- [x] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
- [x] Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.
- [x] Proper changelog labels are set so that the changelog can be generated automatically.
- [ ] If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).
- [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

@daniel-beck
Copy link
Copy Markdown
Member

caused JENKINS-75634

Noting still unanswered #10245 (comment)

@janfaracik
Copy link
Copy Markdown
Member Author

Thanks - will take a look at the issues.


Regarding #10245 (comment) - I apologise, I think that was overlooked in my excitement to get this change merged in. If feedback rolls in that this is impacting users I'll open up a fix for it.

<l:layout permissions="${app.MANAGE_AND_SYSTEM_READ}" title="${%System}" type="one-column">
<st:include page="sidepanel.jelly" />
<f:breadcrumb-config-outline title="${%System}" />
<l:breadcrumb title="${%System}" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused JENKINS-75637

@daniel-beck
Copy link
Copy Markdown
Member

daniel-beck commented May 7, 2025

Thanks - will take a look at the issues.

Regarding #10245 (comment) - I apologise, I think that was overlooked in my excitement to get this change merged in. If feedback rolls in that this is impacting users I'll open up a fix for it.

Earlier user feedback, e.g. #9287 (comment) and following comments, wasn't addressed, so users may not bother to provide feedback at this point. So I don't think waiting for feedback is a good option. We should restore the feature and then determine whether it's used.

@daniel-beck
Copy link
Copy Markdown
Member

daniel-beck commented May 7, 2025

This is basically following

* On the target {@link ModelObject} page, actions are rendered as an item in the side panel
* by the "/lib/hudson:actions" jelly tag, but you can override this for your action by
* writing {@code action.jelly}. See the "actions" tag for what the default handling is and
* tweak from there. One of the use cases of this is to show nested actions, like where
* Jenkins show the option to wipe out the workspace inside the workspace link:
*
* <pre>{@code
* <l:task icon="icon-folder icon-md" href="${url}/ws/" title="${%Workspace}">
* <l:task icon="icon-delete icon-md" href="${url}/wipeOutWorkspace" title="${%Wipe Out Workspace}" />
* </l:task>
* }</pre>

This documentation needs to be updated for this PR to point out how the top-level actions now work.

Previously, the action.jelly is rendered in all cases. From the Jenkins dashboard, the lower link would be hidden automatically due to a trick

<!--
Much of the following horrible code is to implement hierarchy support in <task> tag.
The semantics is that when one of the nested <task> matches, the parent is also considered as a match
and thus gets a highlight.
-->

An example of this is https://plugins.jenkins.io/purge-build-queue-plugin/ which is completely gone from the UI now.
https://github.com/jenkinsci/purge-build-queue-plugin/blob/adeca5c614fe060ce9960dce52399c27d6abf64f/src/main/java/io/jenkins/plugins/PurgeBuildQueueAction.java#L86 didn't matter as the docs Jesse linked point out given https://github.com/jenkinsci/purge-build-queue-plugin/blob/master/src/main/resources/io/jenkins/plugins/PurgeBuildQueueAction/action.jelly, but now it's just vanished.

@scherler
Copy link
Copy Markdown
Contributor

scherler commented May 7, 2025

may have caused JENKINS-75635

@jtnord #10629

@grandinj
Copy link
Copy Markdown

Nice work!

However, there is now a "flash" on the header when scrolling down the page, because it dynamically adds a thin border under the header.

IMNSHO I would say the thin border should just be there always, it provides useful visual separation. Otherwise it should be marked invisible when not needed, so it doesn't trigger a size change when it is turned on.

@janfaracik
Copy link
Copy Markdown
Member Author

Nice work!

However, there is now a "flash" on the header when scrolling down the page, because it dynamically adds a thin border under the header.

IMNSHO I would say the thin border should just be there always, it provides useful visual separation. Otherwise it should be marked invisible when not needed, so it doesn't trigger a size change when it is turned on.

Hey, would you be able to provide a video if poss of the issue? I'm not able to replicate it in Safari/Chrome on macOS.

@grandinj
Copy link
Copy Markdown

All.-.Jenkins.-.Google.Chrome.2025-05-22.14-57-19.mp4

Sure, attaching video. This is Chrome browser running on Windows 10.

@Maxo112
Copy link
Copy Markdown

Maxo112 commented May 28, 2025

Hey guys one question is this compatible with the plugin "Customizable Header" ?
For example if you add custom icon and custom title beside the custom icon

@mawinter69
Copy link
Copy Markdown
Contributor

mawinter69 commented May 28, 2025

Hey guys one question is this compatible with the plugin "Customizable Header" ? For example if you add custom icon and custom title beside the custom icon

yes

image
image

MyText would be the link to the root. Not perfect when you include a link in the title as well

krisstern added a commit to krisstern/jenkins that referenced this pull request Aug 4, 2025
* WB

* Push

* More responsive

* Update headerContent.jelly

* Push

* Update logo.jelly

* Update _page-header.scss

* Update _page-header.scss

* Update header

* Tidy up breadcrumbs

* Tidy up focus

* Update _breadcrumbs.scss

* Update configure.jelly

* push

* Add badges

* Tidy

* Push

* Update headerContent.jelly

* Update ManageJenkinsAction.java

* Update headerContent.jelly

* Working!

* WB

* Tidy up

* Fixes

* Update sidepanel.jelly

* Lint

* Tidy up

* Update ManageJenkinsAction.java

* Simplify

* Update _side-panel-tasks.scss

* Update _side-panel-tasks.scss

* Update UserAction.java

* Update Jenkins.java

* Add border to account image

* Tidy up avatars

* Update _side-panel-tasks.scss

* Init

* Tidy up

* Hide behind flag

* Update sidepanel.jelly

* Push

* Tidy up

* Update logo.jelly

* Accessibility

* Update _breadcrumbs-new.scss

* Fix dropdown theme

* Update _breadcrumbs.scss

* Update _header.scss

* Update ManageJenkinsAction.java

* Remove flag

* Tidy up

* Update with HeaderAction

* Revert "Update with HeaderAction"

This reverts commit 2ea0b1f.

* Tidy

* Update RootAction.java

* Update _breadcrumbs.scss

* Push

* Update _header.scss

* Update _header.scss

* Fix invisible actions not actually being invisible, make avatar huge to please Tim

* Tidy

* Push

* Fix breadcrumbs + notification

* Update jumplist.jelly

* Getting there 🚀

* WB

* Update index.jelly

* Update headerContent.jelly

* Responsive

* Push

* Push

* Push

* Update index.js

* Push

* Tidy up

* Tidy up

* Tidy

* Update logo.jelly

* Delete NewHeaderUserExperimentalFlag.java

* Lint

* Update index.js

* Update index.js

* Fix some tests

* Update headerContent.jelly

* Update headerContent.jelly

* Remove bravo test - need to confirm this

* Update Security3349Test.java

* Update pom.xml

* Fix SpotBugs + i18n

* Add doc for header scroll, support prefers contrast

* Add overflow menu for actions, improve accessibility

* Update actions-overflow.js

* Fix tests + accessibility

* Fix JS

* Update breadcrumbs-overflow.js

* Update breadcrumbs-overflow.js

* Add breadcrumb menu on hover, fix issues on mobile

* Update _breadcrumbs.scss

* i18n

* Update pom.xml

* Add tab support for user dropdown

* Squashed commit of the following:

commit 847981e
Merge: 0ea6dcf 23f2b9e
Author: Kris Stern <krisstern@outlook.com>
Date:   Wed Feb 26 09:16:52 2025 +0800

    Merge branch 'master' into add-groups-to-command-palette

commit 0ea6dcf
Merge: c0777db 68425e2
Author: Kris Stern <krisstern@outlook.com>
Date:   Wed Feb 26 01:06:33 2025 +0800

    Merge branch 'master' into add-groups-to-command-palette

commit c0777db
Merge: 1638afe c37293c
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 24 13:40:35 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 1638afe
Merge: c987a9e b97764d
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Feb 21 11:49:03 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit c987a9e
Merge: f909eec 16748f4
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Feb 20 08:17:19 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit f909eec
Merge: 85eedb7 217b0f5
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Feb 19 16:12:45 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 85eedb7
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Feb 19 16:11:24 2025 +0000

    Move to Item

commit 8f4f117
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Feb 19 15:43:50 2025 +0000

    Tighten up animations + improve contrast

commit d7b7d63
Merge: 8750f7c 4fa6127
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Feb 19 08:50:45 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 8750f7c
Merge: 7b52734 a05c33f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Feb 18 21:42:31 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 7b52734
Merge: e2c133d 3505fb3
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 17 20:59:02 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit e2c133d
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Feb 16 18:23:14 2025 +0000

    Update require-changelog-label.yml

commit d32a61c
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Feb 16 17:11:18 2025 +0000

    Update _theme.scss

commit 42ecfca
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Feb 16 17:10:48 2025 +0000

    Rename to Items

commit cc37791
Merge: 0f1cb21 2b9d4d6
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sun Feb 16 17:10:25 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 0f1cb21
Merge: 04dc6cd 9474c89
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Feb 12 20:42:01 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 04dc6cd
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Feb 11 17:06:31 2025 +0000

    Reduce spacing a touch, fix icon spacing

commit 0ab3665
Merge: 7c9e172 848ac9b
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Feb 11 14:44:03 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 7c9e172
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Feb 11 11:23:27 2025 +0000

    Update Messages.properties

commit ec6a5e5
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Feb 11 08:51:16 2025 +0000

    Fix test

commit 14a6488
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 10 16:44:39 2025 +0000

    Tidy up

commit 46a9e56
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 10 16:28:15 2025 +0000

    Tidy

commit d7270b1
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 10 16:06:04 2025 +0000

    Tidy

commit b2da3f8
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 10 16:03:37 2025 +0000

    Tidy up

commit b746fba
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 10 15:53:53 2025 +0000

    Move to extensionpoint

commit 7827304
Merge: cac127d d03a2e1
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Feb 10 15:45:28 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit cac127d
Merge: add75bf e3e3c45
Author: Tim Jacomb <21194782+timja@users.noreply.github.com>
Date:   Mon Jan 13 11:03:10 2025 +0000

    Merge branch 'jenkinsci:master' into add-groups-to-command-palette

commit add75bf
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jan 11 19:02:52 2025 +0000

    Update _command-palette.scss

commit eb4073f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jan 11 18:59:37 2025 +0000

    Tidy up

commit 323e48f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jan 11 18:47:34 2025 +0000

    Update Job.java

commit 3cbdfbc
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jan 11 18:47:13 2025 +0000

    Update _command-palette.scss

commit 8fecf0d
Merge: 428e826 331c768
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Jan 11 18:45:30 2025 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 428e826
Merge: 5657369 f1b6d31
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Mon Dec 16 20:53:15 2024 +0000

    Merge branch 'master' into add-groups-to-command-palette

commit 5657369
Merge: 26f17a2 674d508
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Dec 13 09:46:35 2024 +0000

    Merge branch 'add-icons-to-command-palette' into add-groups-to-command-palette

commit 674d508
Merge: 809d2e6 7020e80
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Dec 13 09:42:59 2024 +0000

    Merge branch 'master' into add-icons-to-command-palette

commit 26f17a2
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 22:10:56 2024 +0000

    Update _command-palette.scss

commit 2b6ffc8
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 22:09:09 2024 +0000

    Init

commit 809d2e6
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 21:37:47 2024 +0000

    Make iconXml private, rename to icon

commit 3d45ca7
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 21:29:27 2024 +0000

    Add group field

commit 80f24cb
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 21:25:23 2024 +0000

    Init

commit 1b9faa8
Merge: d6868c9 2673844
Author: Tim Jacomb <timjacomb1@gmail.com>
Date:   Wed Dec 11 21:11:56 2024 +0000

    Merge branch 'add-icons-to-command-palette' of github.com:janfaracik/jenkins into add-icons-to-command-palette

commit d6868c9
Author: Tim Jacomb <timjacomb1@gmail.com>
Date:   Wed Dec 11 21:11:41 2024 +0000

    Reword javadoc

commit 2673844
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 21:03:29 2024 +0000

    Implement IconSpec in IComputer

commit 5791010
Merge: 661f994 05ed756
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 20:23:58 2024 +0000

    Merge branch 'master' into add-icons-to-command-palette

commit 661f994
Merge: 2357020 dad5ef3
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 20:15:22 2024 +0000

    Merge branch 'refine-command-palette' into add-icons-to-command-palette

commit 2357020
Merge: 436a02b 788ae63
Author: Tim Jacomb <timjacomb1@gmail.com>
Date:   Wed Dec 11 16:35:43 2024 +0000

    Merge branch 'add-icons-to-command-palette' of github.com:janfaracik/jenkins into add-icons-to-command-palette

commit 436a02b
Author: Tim Jacomb <timjacomb1@gmail.com>
Date:   Wed Dec 11 16:35:24 2024 +0000

    Add support for images

commit a3fdb3e
Merge: ea67d6a d22cc2f
Author: Tim Jacomb <timjacomb1@gmail.com>
Date:   Wed Dec 11 15:27:12 2024 +0000

    Merge branch 'master' into add-icons-to-command-palette

commit 788ae63
Merge: ea67d6a d22cc2f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Wed Dec 11 10:00:04 2024 +0000

    Merge branch 'jenkinsci:master' into add-icons-to-command-palette

commit dad5ef3
Merge: cc63c9c d22cc2f
Author: Tim Jacomb <21194782+timja@users.noreply.github.com>
Date:   Wed Dec 11 09:07:05 2024 +0000

    Merge branch 'master' into refine-command-palette

commit ea67d6a
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Dec 10 22:26:16 2024 +0000

    Update Search.java

commit a9aadba
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Dec 10 22:25:40 2024 +0000

    Revert "Update Search.java"

    This reverts commit 24837ea.

commit 24837ea
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Dec 10 21:59:03 2024 +0000

    Update Search.java

commit d43a8d3
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Dec 10 21:54:23 2024 +0000

    Init

commit cc63c9c
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Tue Dec 10 21:37:09 2024 +0000

    Refine command palette

* Move logo

* Revert "Move logo"

This reverts commit 25647d6.

* Move actions to taglib

* Split logo from breadcrumbs

* Fix sticky app bar

* Update _page-header.scss

* Update HudsonTest.java

* Update _page-header.scss

* Move breadcrumb loading above setting mode to header

* Reduce header height

* Increase logo height

* Move getActions to Header

* Update header avatar with jenkins-avatar

* Squashed commit of the following:

commit 5060044
Merge: 0ea3e49 2fb523f
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Mar 22 17:56:53 2025 +0000

    Merge branch 'master' into improve-tooltips-dropdowns

commit 0ea3e49
Merge: 3dd0b9f a1f9d3e
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Sat Mar 22 12:24:49 2025 +0000

    Merge branch 'master' into improve-tooltips-dropdowns

commit 3dd0b9f
Merge: 7f5f814 73185b2
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Mar 21 09:57:52 2025 +0000

    Merge branch 'master' into improve-tooltips-dropdowns

commit 7f5f814
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Mar 20 10:26:32 2025 +0000

    Update _dropdowns.scss

commit e9eee3c
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Mar 20 10:25:35 2025 +0000

    Update _theme.scss

commit ce11fd1
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Thu Mar 20 10:22:07 2025 +0000

    Init

* Delete idea files

* Update core/src/main/java/jenkins/views/Header.java

Co-authored-by: Markus Winter <m.winter@sap.com>

* Sort actions manually in header

* Update markup and CSS

* Handle that dodgy SVG messing up the label

* Fix new computer missing sidepanel

* Update core/src/main/resources/lib/layout/header/actions.jelly

Co-authored-by: Markus Winter <m.winter@sap.com>

* Update core/src/main/java/jenkins/views/Header.java

Co-authored-by: Markus Winter <m.winter@sap.com>

* Update core/src/main/resources/lib/layout/header/actions.jelly

Co-authored-by: Markus Winter <m.winter@sap.com>

* Update Header.java

---------

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Kris Stern <krisstern@outlook.com>
Co-authored-by: Markus Winter <m.winter@sap.com>
(cherry picked from commit c42ab43)
Comment on lines +14 to +24
<j:forEach var="action" items="${it.actions}">
<dd:item icon="${action.iconFileName}"
text="${action.displayName}"
href="${rootURL}/${it.user.url}/${action.urlName}" />
</j:forEach>

<dd:separator />

<dd:item icon="symbol-log-out"
text="${%Sign out}"
href="${rootURL}/logout" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused SECURITY-3625.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ath-successful This PR has successfully passed the full acceptance-test-harness suite major-rfe For changelog: Major enhancement. Will be highlighted on the top pct-successful This PR has successfully passed the full plugin-compatibility-test suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.