-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grouping to Command Palette #10252
base: master
Are you sure you want to change the base?
Add grouping to Command Palette #10252
Conversation
This reverts commit 24837ea.
…jenkins into add-icons-to-command-palette
…jenkins into add-icons-to-command-palette
If all items are intended to appear there, then it should be "Items". If you only want things representing "projects" there, then regular folders would not be, and in a separate section of "other items". I'm not sure what is the better approach. Having all items there certainly would be simpler (no need to think too hard about what kind of thing in this categorization a multibranch pipeline is…), plus they're currently displayed in the same sort of list as well. So I tentatively prefer this one. This could always be split up later if we don't like it long-term, while merging seems more complicated. Another option might be to (re)use the item type categories that are currently hidden from view (supposed to be temporary in 2016…). Go to "New Item" page and remove the class |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Great. I've renamed |
https://issues.jenkins.io/browse/JENKINS-75312?focusedId=452592&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-452592 Maybe one link or using a form and the submit will lead to the search page again (aka not selecting the first match) could be part of the PR? I am ATM looking into fixing the problem that I mentioned https://issues.jenkins.io/browse/JENKINS-75294?focusedId=452602&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-452602 and stumbled on the other ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. |
This PR adds grouping to the Command Palette, making it easier to identify what each result is.
There are a range of prebuilt groups,
UnclassifiedSearchGroup
,ItemSearchGroup
,ComputerSearchGroup
,ViewSearchGroup
, andUserSearchGroup
. Developers can add custom groups too, for example, Design Library could add a group for its components and patterns.Groups by default don't have a specific ordering, however, the items group is configured to always appear first, and the unclassified group is configured to always appear last. Results are then ordered by name.
I've also done some minor tidy up to the interface, making the overlay a little less invasive.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist