Only limit height of console widget#10368
Conversation
|
I wasn't able to add the following labels: web-ui Check that the label exists and is spelt right then try again. |
|
I wasn't able to add the following labels: web-ui Check that the label exists and is spelt right then try again. |
|
I wasn't able to add the following labels: web-ui Check that the label exists and is spelt right then try again. |
|
I wasn't able to add the following labels: web-ui Check that the label exists and is spelt right then try again. |
|
Build succeeded now. Dont know why it failed in the first run.. |
janfaracik
left a comment
There was a problem hiding this comment.
Tried it locally and works great, thanks!
|
I wasn't able to add the following labels: web-ui Check that the label exists and is spelt right then try again. |
|
Could we get one more look on this @jenkinsci/sig-ux |
timja
left a comment
There was a problem hiding this comment.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
|
I wasn't able to add the following labels: web-ui Check that the label exists and is spelt right then try again. |
PR #10147 changed the layout of the build page.
Unfortunately the height of the Summary is limited to
300pxafter that commit and there is no scrollbar shown for summaries higher than that.This commit just limits the
heightproperty to the console widget.Alternatively a
overflow: scrollcould be added.Maybe @janfaracik might leave a comment on whats more desired.
Testing done
Proposed changelog entries
Proposed changelog category
/label regression-fix,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).