Remove unnecessary SpotBugs suppressions#10391
Merged
krisstern merged 1 commit intojenkinsci:masterfrom Mar 13, 2025
basil:spotbugs
Merged
Remove unnecessary SpotBugs suppressions#10391krisstern merged 1 commit intojenkinsci:masterfrom basil:spotbugs
krisstern merged 1 commit intojenkinsci:masterfrom
basil:spotbugs
Conversation
Contributor
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. /label ready-for-merge |
StefanSpieker
approved these changes
Mar 12, 2025
Contributor
StefanSpieker
left a comment
There was a problem hiding this comment.
Thanks a lot, will also help to continue working on the ones which need triage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amends #10376 by removing more unnecessary SpotBugs suppressions. Where convenient, moved the existing suppressions out of XML into
@SuppressFBWarningsannotations, where unnecessary suppressions will be enforced by SpotBugs itself. Where inconvenient to use@SuppressFBWarnings, kept the supressions in XML but simply removed unnecessary ones.Testing done
mvn clean verify -DskipTestsProposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).