[JENKINS-75444] Filter drop select input is out of style with other components

[ridemountainpig]

See JENKINS-75444.

Testing done

Before

After

Proposed changelog entries

• Update the setting-main and setting-input CSS to allow the plugin to use those themes with the same style as the current one.

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[github-actions]

Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: .

You can add the required label by adding a comment with the following text: /label <category>

[janfaracik]

Is it possible to update the plugin to use the correct div/class instead?

[MarkEWaite]

Is it possible to update the plugin to use the correct div/class instead?

I think so. @mawinter69 proposed two plugin pull requests:

• improve dialog to add credentials credentials-plugin#602
• adjust style of durabilityHint dropdown workflow-job-plugin#517

I think that the plugin pull requests have a much lower risk of unintended consequences.

[mawinter69]

Afaik the setting-input should be considered deprecated. In case we adjust the styling for the new valid classes I'm pretty sure that we will then forget to adjust the setting-input and we again get inconsistent styling.
There are a lot of places in plugins with <select class="input-setting" .... This search has 313 matches, not only select but also some input and textarea tags. It would need to be checked if those are also fixed or if that causes problems.

[MarkEWaite]

I think it would be better to close this pull request in favor of the two plugin pull requests. @ridemountainpig does that work for you?

[ridemountainpig]

I think it would be better to close this pull request in favor of the two plugin pull requests. @ridemountainpig does that work for you?

@MarkEWaite Got it, thank you.