Add an indication of the language of the page in the footer. This enhancement improves accessibility and user experience by explicitly showing the language of the displayed content#10419
Add an indication of the language of the page in the footer. This enhancement improves accessibility and user experience by explicitly showing the language of the displayed content#10419ChongZhe001025 wants to merge 3 commits intojenkinsci:masterfrom ChongZhe001025:master
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
|
I wasn't able to add the following labels: newbie-friendly, user-experience Check that the label exists and is spelt right then try again. |
|
I wasn't able to add the following labels: newbie-friendly, user-experience Check that the label exists and is spelt right then try again. |
|
Thanks for the work on this, but personally I don’t think we should surface the language or page generation time in the UI (which AFAIK was removed from Jenkins a long time ago now). I think for the majority of users this adds noise rather than value. Happy to discuss further if others feel strongly, but my vote would be to leave this out. |
|
I don't see much value in this. Most people know which language they use in their browser. And the truth is that many texts are not translated so we anyway have basically on every page text in english. |
|
Agree with Jan and Markus thanks for your time on this but I don't think its something we want. |
|
Got it! I'm a beginner who just started learning how to solve jenkins issues. May I ask if there are any newbie-friendly issues you would recommend? 🙏 |
|
There's some here which are probably newbie friendly: https://github.com/jenkinsci/sig-ux/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen |
See JENKINS-62419.
Summary
This PR adds an indication of the language of the page in the footer. This enhancement improves accessibility and user experience by explicitly showing the language of the displayed content.
Justification
Even if some localizations are missing, showing a baseline language is useful for users. The locale field should be determined from the response page so that plugins like Locale Plugin are handled correctly. Reference to the Locale Plugin filter:
LocaleFilter.java
Testing done
Implemented changes in Jenkins Core.
Verified that the Request object returns the correct Locale information when using the Locale Plugin.
Screenshots attached:
before:
after:
Proposed changelog entries
Proposed changelog category
/label localization
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).