Skip to content

Add an indication of the language of the page in the footer. This enhancement improves accessibility and user experience by explicitly showing the language of the displayed content#10419

Closed
ChongZhe001025 wants to merge 3 commits intojenkinsci:masterfrom
ChongZhe001025:master

Conversation

@ChongZhe001025
Copy link
Copy Markdown

@ChongZhe001025 ChongZhe001025 commented Mar 19, 2025

See JENKINS-62419.

Summary

This PR adds an indication of the language of the page in the footer. This enhancement improves accessibility and user experience by explicitly showing the language of the displayed content.

Justification

Even if some localizations are missing, showing a baseline language is useful for users. The locale field should be determined from the response page so that plugins like Locale Plugin are handled correctly. Reference to the Locale Plugin filter:
LocaleFilter.java

Testing done

  • Implemented changes in Jenkins Core.

  • Verified that the Request object returns the correct Locale information when using the Locale Plugin.

  • Screenshots attached:

    before:

    screenshot-before

    after:

    screenshot-en
    screenshot-ru
    screenshot-tr

Proposed changelog entries

  • Indicate the language of the page in the footer to improve accessibility and user experience.

Proposed changelog category

/label localization

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate.
  • There is automated testing or an explanation for the lack of tests.
  • New public classes, fields, and methods are annotated appropriately.
  • For dependency updates, external changelogs and full differentials are linked.
  • For new APIs, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 19, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added the accessibility Improve accessibility per WCAG guidelines label Mar 19, 2025
@comment-ops-bot
Copy link
Copy Markdown

I wasn't able to add the following labels: newbie-friendly, user-experience

Check that the label exists and is spelt right then try again.

@comment-ops-bot
Copy link
Copy Markdown

I wasn't able to add the following labels: newbie-friendly, user-experience

Check that the label exists and is spelt right then try again.

@janfaracik
Copy link
Copy Markdown
Member

Thanks for the work on this, but personally I don’t think we should surface the language or page generation time in the UI (which AFAIK was removed from Jenkins a long time ago now). I think for the majority of users this adds noise rather than value.

Happy to discuss further if others feel strongly, but my vote would be to leave this out.

@mawinter69
Copy link
Copy Markdown
Contributor

I don't see much value in this. Most people know which language they use in their browser. And the truth is that many texts are not translated so we anyway have basically on every page text in english.
We have so many pages with dynamic content so the timestamp when the page was generated is not saying much. And when the page is a bit longer the footer is anyway not visible, you would first need to scroll to the end to see that information. I've never missed this since it was removed.

@timja
Copy link
Copy Markdown
Member

timja commented Mar 19, 2025

Agree with Jan and Markus thanks for your time on this but I don't think its something we want.

@timja timja added the proposed-for-close There is no consensus about feasibility of this PR, and maintainers do not see a way forward for it label Mar 19, 2025
@ChongZhe001025
Copy link
Copy Markdown
Author

Got it! I'm a beginner who just started learning how to solve jenkins issues. May I ask if there are any newbie-friendly issues you would recommend? 🙏

@timja timja closed this Mar 21, 2025
@timja
Copy link
Copy Markdown
Member

timja commented Mar 21, 2025

There's some here which are probably newbie friendly: https://github.com/jenkinsci/sig-ux/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Improve accessibility per WCAG guidelines localization proposed-for-close There is no consensus about feasibility of this PR, and maintainers do not see a way forward for it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants