test: refactor XML test to use explicit assertions and clearer structure#10847
Closed
Rian-Ismael wants to merge 1 commit intojenkinsci:masterfrom
Closed
test: refactor XML test to use explicit assertions and clearer structure#10847Rian-Ismael wants to merge 1 commit intojenkinsci:masterfrom
Rian-Ismael wants to merge 1 commit intojenkinsci:masterfrom
Conversation
comment-ops-bot
bot
added
the
rfe
MarkEWaite
added
tests
Contributor
The test that you added fails on Windows and Linux on ci.jenkins.io. Failing tests are a sign that you've not understood the code that you're changing. Please correct the error that causes the test to fail. |
MarkEWaite
requested changes
Jul 27, 2025
|
|
||
| @Test | ||
| void canReadXml1_0Test() throws IOException { | ||
| public void canReadXml1_0WhenFileExists() throws IOException { |
Contributor
There was a problem hiding this comment.
JUnit 5 does not require that the test method is public. Please leave this line unchanged.
Suggested change
| public void canReadXml1_0WhenFileExists() throws IOException { | |
| void canReadXml1_0Test() throws IOException { |
Contributor
|
Please don't submit pull requests from a branch named "master". It complicates things for reviewers. Please restore the entire pull request checklist. |
Contributor
|
Closing the pull request after a week with no response to the request for changes. |
comment-ops-bot
bot
added
the
rfe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing done
This change was tested by running the affected test class via IntelliJ and Maven. The test executes successfully, validating that the XML file is read correctly and the expected assertions pass.
No production logic was changed.
Proposed changelog entries
/label rfe
Proposed changelog category
/label
internalProposed upgrade guidelines
N/A
Submitter checklist