Skip to content

Replaced jquery usage with plain javascript on page.js#10859

Merged
NotMyFault merged 1 commit intojenkinsci:masterfrom
StefanSpieker:jquery_page
Jul 30, 2025
Merged

Replaced jquery usage with plain javascript on page.js#10859
NotMyFault merged 1 commit intojenkinsci:masterfrom
StefanSpieker:jquery_page

Conversation

@StefanSpieker
Copy link
Copy Markdown
Contributor

@StefanSpieker StefanSpieker commented Jul 20, 2025

See JENKINS-XXXXX.

Testing done

Started in debug environment and did not notice any difference

Proposed changelog entries

  • Replace jQuery usage with plain JavaScript.

Proposed changelog category

/label internal

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@krisstern krisstern requested a review from a team July 21, 2025 16:24
Copy link
Copy Markdown

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor changes.

Copy link
Copy Markdown
Member

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@krisstern krisstern requested a review from a team July 22, 2025 17:21
@krisstern
Copy link
Copy Markdown
Member

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 29, 2025
@NotMyFault NotMyFault merged commit 4915d61 into jenkinsci:master Jul 30, 2025
18 checks passed
@StefanSpieker StefanSpieker deleted the jquery_page branch July 30, 2025 15:21
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants