Fix word breaking in pre tags and help classes#10881
Fix word breaking in pre tags and help classes#10881krisstern merged 4 commits intojenkinsci:masterfrom
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
|
Re-running some CI/CD checks due to some failed flaky tests earlier |
|
For the ERROR:
Unexpected deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated) |
…ow-wrap: anywhere` and `word-break: normal`
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
word-wrapis an alias foroverflow-wrapand only has the supported valuesnormal | break-word | anywhere | [initial | inherit | unset | revert | revert-layer]1.I am assuming the intention in the
prestyling was to have it set up to break on each word.I have made the same assumption with the
word-breakproperty for the.helpwhich only supports the valuesnormal | break-all | keep-all | manual | auto-phrase | break-word | [initial | inherit | unset | revert | revert-layer]2.Testing done
Manual visual regression check
Proposed changelog entries
word-wrapandword-breakCSS properties to use supported values.Proposed changelog category
/label web-ui, bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).Footnotes
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap#syntax ↩
https://developer.mozilla.org/en-US/docs/Web/CSS/word-break#syntax ↩