Skip to content

[JENKINS-75879] GStringTemplateEngine causes memory leak in class loading #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basil merged 3 commits into from
Aug 14, 2025
Merged

[JENKINS-75879] GStringTemplateEngine causes memory leak in class loading #10938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
066593e
[JENKINS-75879] - GStringTemplateEngine causes memory leak in ClassLo…
jgarciacloudbees Aug 8, 2025
c6683c5
[JENKINS-75879] - Change class prefix name to constant
jgarciacloudbees Aug 12, 2025
e496b07
[JENKINS-75879] - Apply code suggestions
jgarciacloudbees Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions core/src/main/java/hudson/PluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,14 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
*/
/* private final */ static int CHECK_UPDATE_ATTEMPTS;

/**
* Class name prefixes to skip in the class loading
*/
private static final String[] CLASS_PREFIXES_TO_SKIP = {
"SimpleTemplateScript", // cf. groovy.text.SimpleTemplateEngine
"groovy.tmp.templates.GStringTemplateScript", // Leaks on classLoader in some cases, see JENKINS-75879
};

static {
try {
// Secure initialization
Expand Down Expand Up @@ -2409,8 +2417,10 @@ public UberClassLoader(List<PluginWrapper> activePlugins) {

@Override
protected Class<?> findClass(String name) throws ClassNotFoundException {
if (name.startsWith("SimpleTemplateScript")) { // cf. groovy.text.SimpleTemplateEngine
throw new ClassNotFoundException("ignoring " + name);
for (String namePrefixToSkip : CLASS_PREFIXES_TO_SKIP) {
if (name.startsWith(namePrefixToSkip)) {
throw new ClassNotFoundException("ignoring " + name);
}
}
return loaded.computeIfAbsent(name, this::computeValue).orElseThrow(() -> new ClassNotFoundException(name));
}
Expand Down