show parameters of a run with readOnlyMode

[mawinter69]

Display the parameters that have been used for a run with readOnlyMode instead of using the readonly attribute. This is the recommended way.

Also removes the inline javascript when a checkbox sets readonly="true". This is only used in very few places and should not have an effect on plugins. A f:checkbox that still uses readonly will then be rendered disabled

Before:

After:

Testing done

Interactive testing

Proposed changelog entries

• Show parameters of a run in read only mode.

Proposed changelog category

/label rfe,web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

LGTM

---

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[A1exKH]

LGTM.

[daniel-beck]

#8420 (comment) points out this changes the semantics of form submission. Could this cause trouble?

CC @zbynek as comment author

[mawinter69]

I checked where checkboxes with readonly="true" are used. I found 6 plugins:

• artifact-manager-s3: 2 places the underlying fields are final and the value is set from a system property -> no problem
• admin-params: used to show a parameter value in the parameters page of a run -> no problem
• google-compute-egine: the underlying field is static final -> no problem
• agent-maintenance: also sets readOnlyMode -> no problem
• nodejs: used in show-config.jelly this only shows the config and should not be editable anyway -> no problem
• matrix-combinations: used to show a parameter value in the parameters page of a run -> no problem

[timja]

Did you check with a screen reader?

[mawinter69]

ahh yes that could be a problem.

But then any place where we set readOnlyMode that leads to a disabled input is problematic. E.g. in radio.jelly, radioBlock.jelly toggleSwitch.jelly, enum.jelly