Apply staticanalysis.RemoveUnusedPrivateMethods#10962
Apply staticanalysis.RemoveUnusedPrivateMethods#10962Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
staticanalysis.RemoveUnusedPrivateMethods#10962Conversation
|
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: . You can add the required label by adding a comment with the following text: |
|
BUILD SUCCESS Kindly request some feedback. Thanks. |
| fullName = i.getFullName(); | ||
| } | ||
|
|
||
| private Object readResolve() { |
There was a problem hiding this comment.
Do not remove any method with name readResolve or writeReplace
These methods even when private are used by during serialization of Objects.
| public abstract static class Base<T> { | ||
| protected abstract void method(); | ||
|
|
||
| private void aPrivateMethod() {} |
There was a problem hiding this comment.
The test in line 78 explicitly expects this method.
| return true; | ||
| } | ||
|
|
||
| private Object writeReplace() { |
There was a problem hiding this comment.
There was a problem hiding this comment.
So there's a conditional that checks if the class implements serializable; that appears not to be the case here; I think we can just remove that condition and just never remove methods with any of those names.
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks once again, teamwork makes the dreamwork.
|
reopen after 2.15.1 release. |
3 participants
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).