Skip to content

fix confusion on duplicated field ProcessTree#PR_MODEL_ILP32#10967

Closed
Pankraz76 wants to merge 9 commits intojenkinsci:masterfrom
Pankraz76:rw-RemoveUnused-fix-PR_MODEL_ILP32
Closed

fix confusion on duplicated field ProcessTree#PR_MODEL_ILP32#10967
Pankraz76 wants to merge 9 commits intojenkinsci:masterfrom
Pankraz76:rw-RemoveUnused-fix-PR_MODEL_ILP32

Conversation

@Pankraz76
Copy link

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@github-actions
Copy link
Contributor

Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: .

You can add the required label by adding a comment with the following text: /label <category>


/*
* Make a sysctl() call to get the raw argument space of the
* process. The layout is documented in start.s, which is part
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the whole project config seems to be broken considering spotless, check, git, being out of sync as this is the prove of it.

@Pankraz76
Copy link
Author

@Pankraz76

This comment was marked as resolved.

@Pankraz76
Copy link
Author

Pankraz76 commented Aug 14, 2025

test locally not working:

   0.047 [id=3]	INFO	o.jvnet.hudson.test.JenkinsRule#createWebServer2: Running on http://localhost:54990/jenkins/
   0.055 [id=3]	INFO	jenkins.model.Jenkins#<init>: Starting version 2.524-SNAPSHOT
   0.063 [id=270]	INFO	jenkins.InitReactorRunner$1#onAttained: Started initialization
   0.064 [id=282]	INFO	jenkins.InitReactorRunner$1#onAttained: Listed all plugins
   0.065 [id=282]	INFO	j.b.api.BouncyCastlePlugin#start: /Users/vincent.potucek/IdeaProjects/jenkins/test/target/j h12158678340375920600/plugins/bouncycastle-api/WEB-INF/optional-lib not found; for non RealJenkinsRule this is fine and can be ignored.
   0.130 [id=280]	INFO	jenkins.InitReactorRunner$1#onAttained: Prepared all plugins
   0.131 [id=274]	INFO	jenkins.InitReactorRunner$1#onAttained: Started all plugins
   0.131 [id=269]	INFO	jenkins.InitReactorRunner$1#onAttained: Augmented all extensions
   0.228 [id=277]	INFO	jenkins.InitReactorRunner$1#onAttained: System config loaded
   0.229 [id=282]	INFO	jenkins.InitReactorRunner$1#onAttained: System config adapted
   0.229 [id=280]	INFO	jenkins.InitReactorRunner$1#onAttained: Loaded all jobs
   0.229 [id=273]	INFO	jenkins.InitReactorRunner$1#onAttained: Configuration for all jobs updated
   0.231 [id=281]	INFO	jenkins.InitReactorRunner$1#onAttained: Completed initialization
   0.930 [id=3]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
   0.936 [id=3]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
   0.956 [id=3]	INFO	o.j.h.t.TemporaryDirectoryAllocator#dispose: deleting /Users/vincent.potucek/IdeaProjects/jenkins/test/target/j h12158678340375920600

java.lang.AssertionError: 
Expected: not a string containing "sleep 100000"
     but: was "Legacy code started this job.  No cause information is available\nRunning as SYSTEM\nBuilding in workspace /Users/vincent.potucek/IdeaProjects/jenkins/test/target/j h12158678340375920600/workspace/test1\n[test1] $ /bin/sh -xe /Users/vincent.potucek/IdeaProjects/jenkins/test/target/jenkins4362317496408618315.sh\n+ ps -ef\n+ grep sleep\n  501   794   723   0  3:55PM ??         0:00.00 sleep 31536000\n  501 13670     1   0 11:45AM ??         0:00.00 sleep 100000\n  501 13756     1   0 11:46AM ??         0:00.00 sleep 100000\n  501 13815     1   0 11:46AM ??         0:00.00 sleep 100000\n  501 13916     1   0 11:46AM ??         0:00.00 sleep 100000\n  501 13922 13920   0 11:46AM ??         0:00.00 grep sleep\nFinished: SUCCESS\n"
<Click to see difference>


	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.jvnet.hudson.test.JenkinsRule.assertLogNotContains(JenkinsRule.java:1543)
	at hudson.util.ProcessTreeTest.processProperlyKilledUnix(ProcessTreeTest.java:97)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)


*/
public abstract class ProcessTree implements Iterable<OSProcess>, IProcessTree, SerializableOnlyOverRemoting {
private static final byte PR_MODEL_ILP32 = 0;
private static final byte PR_MODEL_LP64 = 1;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming its probably wrong and or a test blindspot.

@NotMyFault NotMyFault closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants