Skip to content

activate missing check goal of maven-spotless-plugin#10968

Closed
Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
Pankraz76:fix-maven-checkstyle-plugin
Closed

activate missing check goal of maven-spotless-plugin#10968
Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
Pankraz76:fix-maven-checkstyle-plugin

Conversation

@Pankraz76
Copy link

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@github-actions
Copy link
Contributor

Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: .

You can add the required label by adding a comment with the following text: /label <category>

pom.xml Outdated
<executions>
<execution>
<goals>
<goal>check</goal>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applying spotless changes everything this has to be done once or the config needs to be aligned with check. Its only possible because spotless is not activated by default...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<goal>check</goal>
</goals>
<phase>validate</phase>
<phase>verify</phase>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pankraz76
Copy link
Author

@oowekyala
@adangel

consider this as positive and negative example. They need to apply spotless once then they can use it. or fix the config just like in PMD....

@Pankraz76

This comment was marked as resolved.

@Pankraz76
Copy link
Author

So the issue is caused when moving the plugin to the pluginManagement section as the checkstyle and as expected.

This changed the config somehow and then the entire project.

Having applied spotless myself i know this could not be. When there is spotless there is out of sync possible.

@NotMyFault NotMyFault closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants