fix missing plugin mentioning of spotbugs and spotless in CONTRIBUTING.md#10971
Closed
Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
Closed
fix missing plugin mentioning of spotbugs and spotless in CONTRIBUTING.md#10971Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
MarkEWaite
requested changes
Aug 14, 2025
| ``` | ||
|
|
||
| To fix frontend issues, after [optionally adding Node and Yarn to your path](#running-the-yarn-frontend-build), run: | ||
| To automatically fix frontend issues, run: |
Contributor
There was a problem hiding this comment.
The link to adding Node and Yarn was intentionally added for the benefit of developers like me that mostly work in backend code. I don't have Node and Yarn in my path usually and the link helps me find the extra steps that I need to use on those rare times when I need to run yarn lint:fix
More discussion of the reason for that phrasing is in:
Suggested change
| To automatically fix frontend issues, run: | |
| To fix frontend issues, after [optionally adding Node and Yarn to your path](#running-the-yarn-frontend-build), run: |
Member
|
Agreed with Mark, this should rather stay as is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).