Skip to content

Stray } in CollapsedMulti#10977

Merged
timja merged 2 commits intojenkinsci:masterfrom
jglick:CollapsedMulti
Aug 16, 2025
Merged

Stray } in CollapsedMulti#10977
timja merged 2 commits intojenkinsci:masterfrom
jglick:CollapsedMulti

Conversation

@jglick
Copy link
Member

@jglick jglick commented Aug 15, 2025

Glitch in #9177, actually visible in one of the screenshots there.

Testing done

  • disabled built-in node
  • created two inbound agents (did not bother to connect them) each with several executors
  • collapsed executor widget
  • observed appearance before vs. after change

Proposed changelog entries

N/A

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Desired reviewers

@mawinter69

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the skip-changelog Should not be shown in the changelog label Aug 15, 2025
@jglick jglick requested a review from mawinter69 August 15, 2025 17:35
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 15, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timja timja merged commit 1e05e67 into jenkinsci:master Aug 16, 2025
13 of 16 checks passed
@jglick jglick deleted the CollapsedMulti branch August 18, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants