-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Move common caching class loading functionality to the separate class #10979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
krisstern
merged 1 commit into
jenkinsci:master
from
dukhlov:improve-classloader-caching
Sep 2, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package hudson.util; | ||
|
|
||
| import java.util.Optional; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import org.kohsuke.accmod.Restricted; | ||
| import org.kohsuke.accmod.restrictions.NoExternalUse; | ||
|
|
||
| /** | ||
| * | ||
| * ClassLoader with internal caching of class loading results. | ||
| * | ||
| * <p> | ||
| * Caches both successful and failed class lookups to avoid redundant delegation | ||
| * and repeated class resolution attempts. Designed for performance optimization | ||
| * in systems that repeatedly query class presence (e.g., plugin environments, | ||
| * reflective loading, optional dependencies). | ||
| * </p> | ||
| * | ||
| * Useful for classloaders that have heavy-weight loadClass() implementations | ||
| * | ||
| * @author Dmytro Ukhlov | ||
| */ | ||
| @Restricted(NoExternalUse.class) | ||
| public class CachingClassLoader extends DelegatingClassLoader { | ||
| private final ConcurrentHashMap<String, Object> cache = new ConcurrentHashMap<>(); | ||
|
|
||
| public CachingClassLoader(String name, ClassLoader parent) { | ||
| super(name, parent); | ||
| } | ||
|
|
||
| @Override | ||
| protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException { | ||
| Object classOrEmpty = cache.computeIfAbsent(name, key -> { | ||
| try { | ||
| return super.loadClass(name, false); | ||
| } catch (ClassNotFoundException e) { | ||
| // Not found. | ||
| return Optional.empty(); | ||
| } | ||
| }); | ||
|
|
||
| if (classOrEmpty == Optional.empty()) { | ||
| throw new ClassNotFoundException(name); | ||
| } | ||
|
|
||
| Class<?> clazz = (Class<?>) classOrEmpty; | ||
| if (resolve) { | ||
| resolveClass(clazz); | ||
| } | ||
| return clazz; | ||
| } | ||
|
|
||
| public void clearCacheMisses() { | ||
| cache.values().removeIf(v -> v == Optional.empty()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Maybe the using
Optionalas map value type could make its usage more natural. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping with Optional consumes a bit more memory, so I decided not to use it. However, I agree it makes the code more natural. Let's wait for further reviews before making a final decision.