Revert "Update dependency org.jenkins-ci.main:jenkins-test-harness to v2505"

[NotMyFault]

Reverts #11106

As per jenkinsci/jenkins-test-harness#1031

[MarkEWaite]

An incremental build of the master branch (prior to this pull request) in the plugin BOM passed the http request plugin test. The change I made in the plugin BOM was:

diff --git a/sample-plugin/pom.xml b/sample-plugin/pom.xml
index 39f21e97..b00aa8a9 100644
--- a/sample-plugin/pom.xml
+++ b/sample-plugin/pom.xml
@@ -14,7 +14,7 @@
   <properties>
     <changelist>999999-SNAPSHOT</changelist>
     <bom>weekly</bom>
-    <jenkins.version>2.529</jenkins.version>
+    <jenkins.version>2.530-rc37523.097a_5b_2f3403</jenkins.version>
     <spotless.check.skip>false</spotless.check.skip>
   </properties>
   <dependencyManagement>

I ran the plugin BOM test with the command:

PLUGINS=http_request TEST=HttpRequestTest#sendUTF8RequestBody LINE=weekly bash ./local-test.sh

The http request plugin test fails if I use the incremental build of the master branch and also upgrade the Jenkins test harness version in the test. The change I made in the plugin BOM for that was:

diff --git a/pct.sh b/pct.sh
index 86fec40d..de204d43 100755
--- a/pct.sh
+++ b/pct.sh
@@ -21,7 +21,7 @@ if ! [[ $PLUGINS =~ blueocean || $PLUGINS =~ lockable-resources || $PLUGINS =~ p
 fi

 # Tracked by .github/renovate.json
-JTH_VERSION=2493.vcc1b_74b_c433f
+JTH_VERSION=2505.v4a_e1e6f69d4e
 if [[ $LINE == weekly ]]; then
        PCT_D_ARGS+="-Djenkins-test-harness.version=${JTH_VERSION} "
 fi
diff --git a/sample-plugin/pom.xml b/sample-plugin/pom.xml
index 39f21e97..b00aa8a9 100644
--- a/sample-plugin/pom.xml
+++ b/sample-plugin/pom.xml
@@ -14,7 +14,7 @@
   <properties>
     <changelist>999999-SNAPSHOT</changelist>
     <bom>weekly</bom>
-    <jenkins.version>2.529</jenkins.version>
+    <jenkins.version>2.530-rc37523.097a_5b_2f3403</jenkins.version>
     <spotless.check.skip>false</spotless.check.skip>
   </properties>
   <dependencyManagement>

I ran the plugin BOM test with the command:

PLUGINS=http_request TEST=HttpRequestTest#sendUTF8RequestBody LINE=weekly bash ./local-test.sh

Unfortunately, I'm not sure what that means. Upgrading Jenkins test harness to 2505.x inside Jenkins core does not break the plugin BOM test of http request plugin, but upgrading Jenkins test harness to 2505.x in the plugin BOM does break it.

I also confirmed that the http request plugin test is not broken when run with the incremental of Jenkins core inside the http request plugin repository. The changes I tested in the http request plugin repository look like this:

diff --git a/pom.xml b/pom.xml
index 55dfe22..7a162ec 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,8 +53,9 @@ THE SOFTWARE.
                <gitHubRepo>jenkinsci/http-request-plugin</gitHubRepo>
                <!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
                <jenkins.baseline>2.479</jenkins.baseline>
-               <jenkins.version>${jenkins.baseline}.3</jenkins.version>
-               <jenkins-test-harness.version>2505.v4a_e1e6f69d4e</jenkins-test-harness.version>
+               <!-- <jenkins.version>${jenkins.baseline}.3</jenkins.version> -->
+               <jenkins.version>2.530-rc37523.097a_5b_2f3403</jenkins.version>
+               <!-- <jenkins-test-harness.version>2505.v4a_e1e6f69d4e</jenkins-test-harness.version> -->
                <spotbugs.effort>Max</spotbugs.effort>
                <spotbugs.failOnError>true</spotbugs.failOnError>
                <spotbugs.threshold>Low</spotbugs.threshold>

The command I used to run those tests was:

mvn clean -Dtest=HttpRequestTest#sendUTF8RequestBody test

When I uncomment the upgrade to Jenkins test harness 2505.x in that change to http request plugin, then the test fails

[NotMyFault]

Interesting analysis, I try to take a look later this week 👀

[MarkEWaite]

I think that we can safely close this pull request. I've had some tutoring from @jglick that should allow me to find the change in Jetty 12.1.1 that is causing the test failure in the http request plugin. The winstone 8.14 release includes Jetty 12.1.1 and stapler release 2033.va_95221851a_23 depends on Jetty 12.1.1 .

@alecharp is also exploring the use of Jetty 12.1.1 in the context of Java 25 with a draft pull request at:

• Enable Java 25 support #11148