Skip to content

Update the ReadMe#11147

Merged
MarkEWaite merged 13 commits intojenkinsci:masterfrom
Pnkcaht:master
Dec 1, 2025
Merged

Update the ReadMe#11147
MarkEWaite merged 13 commits intojenkinsci:masterfrom
Pnkcaht:master

Conversation

@Pnkcaht
Copy link
Contributor

@Pnkcaht Pnkcaht commented Oct 2, 2025

N/A – Moderate documentation improvement, no issues with Jira.

Tests completed

N/A – Changes only to Markdown. No functional code affected.

Proposed changelog entries

  • Improve README.md with a better structure, usage instructions, and a table of contents to improve the visuals and efficiency of the readme documentation, guidelines for contributors, and clarity in explanations with more content and even photos showing the user what the site looks like.

Proposed changelog category

/label skip-changelog

Proposed update guidelines

N/A

Captura de tela de 2025-10-02 20-54-04 Captura de tela de 2025-10-02 20-54-15 Captura de tela de 2025-10-02 20-54-19

@welcome
Copy link

welcome bot commented Oct 2, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added the skip-changelog Should not be shown in the changelog label Oct 2, 2025
@Pnkcaht
Copy link
Contributor Author

Pnkcaht commented Oct 2, 2025

Hello, I've noticed the lack of content in the readme for some time now. Even though it's not that important, it helps a lot, and I've made the adjustments. If you need more content, if something is wrong or broken, or if I need to change the position, please let me know. Thank you, and I'm happy to help the Jenkins community. ❤️

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in contributing to Jenkins. Unfortunately, there are many errors in your proposed changes.

The pull request would have benefited significantly if you had checked that the commands work that are included in the pull request.

This looks like it might have been generated by AI without sufficient proofreading by the user submitting the text. Please spend your time as a contributor to assure that the pull request is accurate. There are many more contributors than there are reviewers.

@MarkEWaite MarkEWaite changed the title Important update to the ReadMe Update the ReadMe Oct 3, 2025
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of the file needs to be corrected as well. Instructions for formatting are included in the contributing guide.

@Pnkcaht
Copy link
Contributor Author

Pnkcaht commented Oct 3, 2025

I agree, I saw it here and it really does contain errors, I will resolve them immediately and ensure everything is 100% correct to be finalized ❤️

Pnkcaht and others added 3 commits October 2, 2025 23:44
Also format with `yarn lint:fix` as noted in the contributing guide.
@MarkEWaite
Copy link
Contributor

In the future, please use a branch that is named something other than master. When you use the branch named master, you complicate your local work with the repository and you complicate the work of the reviewer.

@Pnkcaht
Copy link
Contributor Author

Pnkcaht commented Oct 3, 2025

Okay, thanks for the feedback. I won't be adding that branch name in future contributions. Do you think anything else is needed in the ReadMe?

@Pnkcaht Pnkcaht requested a review from MarkEWaite October 3, 2025 17:48
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MarkEWaite MarkEWaite added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Oct 3, 2025
@MarkEWaite
Copy link
Contributor

Okay, thanks for the feedback. I won't be adding that branch name in future contributions. Do you think anything else is needed in the ReadMe?

I didn't see anything missing in my first review, but I'll leave the pull request open to wait for a second review.

README.md Outdated
Comment on lines +75 to +77
- Check our [friendly issues](https://issues.jenkins.io/issues/?jql=labels%20%3D%20newbie-friendly%20AND%20resolution%20is%20empty%20AND%20component%20%3D%20core)
- Join our [Gitter chat](https://app.gitter.im/#/room/#jenkinsci_newcomer-contributors:gitter.im) for questions and help
- Read the [Contribution Guidelines](CONTRIBUTING.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Check our [friendly issues](https://issues.jenkins.io/issues/?jql=labels%20%3D%20newbie-friendly%20AND%20resolution%20is%20empty%20AND%20component%20%3D%20core)
- Join our [Gitter chat](https://app.gitter.im/#/room/#jenkinsci_newcomer-contributors:gitter.im) for questions and help
- Read the [Contribution Guidelines](CONTRIBUTING.md)
- Read the [Contribution Guidelines](CONTRIBUTING.md)
- Check our [friendly issues](https://issues.jenkins.io/issues/?jql=labels%20%3D%20newbie-friendly%20AND%20resolution%20is%20empty%20AND%20component%20%3D%20core)
- Join our [Gitter chat](https://app.gitter.im/#/room/#jenkinsci_newcomer-contributors:gitter.im) for questions and help

Suggestion: read CONTRIBUTING.md first


Jenkins is used by millions of users and thousands of companies.
See [adopters](https://www.jenkins.io/project/adopters/) for the list of Jenkins adopters and their success stories.
Jenkins is trusted by **millions of users** and adopted by **thousands of companies** around the world — from startups to enterprises — to automate their software delivery pipelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal opinion: not sure about that change, the "adopted" seems a bit strange to me (then english is not my native language)

Also, do we really want those em-dashes? 😅

README.md Outdated
See [adopters](https://www.jenkins.io/project/adopters/) for the list of Jenkins adopters and their success stories.
Jenkins is trusted by **millions of users** and adopted by **thousands of companies** around the world — from startups to enterprises — to automate their software delivery pipelines.

Explore the [Adopters Page](https://www.jenkins.io/project/adopters/) to see:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Explore the [Adopters Page](https://www.jenkins.io/project/adopters/) to see:
Explore the [Adopters Page](https://www.jenkins.io/project/adopters/) and https://stories.jenkins.io to see:

suggestion: add stories.jenkins.io link

README.md Outdated

---

# 📌 Table of Contents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 📌 Table of Contents
# Table of Contents

Personal opinion: there is currently no emoji on the README, I would avoid adding one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to the reader's eyes, it makes it easier and provides more clarity, but I'll remove it as you asked.

@Pnkcaht
Copy link
Contributor Author

Pnkcaht commented Oct 3, 2025

@lemeurherve I have already applied the changes you requested, thank you, I think it is now ok for the merge

@lemeurherve
Copy link
Member

@Vyzer9 can you keep conversations unresolved until there is a change or acknowlegment please? (ex: #11147 (comment))

It makes it easier to follow for everyone.

@Pnkcaht
Copy link
Contributor Author

Pnkcaht commented Oct 5, 2025

@lemeurherve Ok, I've already left it as unresolved, the other brother reviewed and approved the others.

@Pnkcaht
Copy link
Contributor Author

Pnkcaht commented Oct 5, 2025

@lemeurherve I left it there as unresolved but I have already made all the requested changes, I will be waiting for the response and possible merge

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue tracker is moving to GitHub issues on Monday. I asked about the 'good first issue' label in a post to the developer list.

README.md Outdated
New to open source or Jenkins? Here’s how to get started:

- Read the [Contribution Guidelines](CONTRIBUTING.md)
- Check our [friendly issues](https://issues.jenkins.io/issues/?jql=labels%20%3D%20newbie-friendly%20AND%20resolution%20is%20empty%20AND%20component%20%3D%20core)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be revised Monday Nov 24, 2025 when the issue tracking for Jenkins core moves from Jenkins Jira to GitHub issues.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL for good first issues needs to be updated now that we've switched Jenkins core issues from Jira to GitHub.

@MarkEWaite MarkEWaite self-requested a review November 30, 2025 12:27
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 30, 2025
@MarkEWaite MarkEWaite merged commit 6731b97 into jenkinsci:master Dec 1, 2025
18 checks passed
@welcome
Copy link

welcome bot commented Dec 1, 2025

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


karthikbhandary2 pushed a commit to karthikbhandary2/jenkins that referenced this pull request Dec 4, 2025
* Update README.md

* Update README.md

* Update README.md

* Remove link to non-existent newsletter

Also format with `yarn lint:fix` as noted in the contributing guide.

* Update README.md

* Update good first issues query

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Kris Stern <krisstern@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants