feat(jdk): add getJavaVersion() and improve Javadocs#11160
feat(jdk): add getJavaVersion() and improve Javadocs#11160miracneroid wants to merge 3 commits intojenkinsci:masterfrom miracneroid:hacktoberfest-fix
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
|
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: . You can add the required label by adding a comment with the following text: |
MarkEWaite
left a comment
There was a problem hiding this comment.
Please assure that your code changes successfully compile and pass tests before submitting a pull request. Refer to the contributing guide for guidance to compile and test Jenkins core.
Please complete the pull request template when submitting a pull request. It wastes the time of maintainers to review pull requests that do not complete the pull request template.
If you are choosing to use the title format of conventional commits, please use them accurately. In this case, you added a test but used the conventional commit text that indicates this is a feature. New automated tests are not features.
I will close this pull request on the assumption that if you decide to fix the code so that it compiles and passes tests, you can reopen it.
| @@ -0,0 +1,32 @@ | |||
| package hudson.model; | |||
|
|
|||
| import org.junit.Test; | |||
There was a problem hiding this comment.
Please use JUnit 5 for tests instead of JUnit 4.
| import org.junit.Test; | |
| import org.junit.jupiter.api.Test; |
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * copies, and to permit persons to whom the Software is furnished to do so, | ||
| * subject to the following conditions: |
There was a problem hiding this comment.
Please don't change the license of existing source files.
| * subject to the following conditions: | |
| * copies of the Software, and to permit persons to whom the Software is | |
| * furnished to do so, subject to the following conditions: |
|
We strongly prefer that new API's are not added to Jenkins core unless there are also consumers of the API. |
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).Summary
This PR enhances the JDK class in Jenkins by:
getJavaVersion()to detect the installed JDK version.Motivation
Provides a useful utility method for developers and improves code readability and maintainability.
Notes
Summary
This PR enhances the JDK class in Jenkins by:
getJavaVersion()to detect the installed JDK version.Motivation
Provides a useful utility method for developers and improves code readability and maintainability.