[JENKINS-76202] Avoid stack overflow when new run UI is enabled

[mawinter69]

The combination of a maven job with a run, naginator plugin installed and the new run UI enabled leads to a stack overflow when accessing the All view and also when accessing the maven job.

See JENKINS-76202 for more details.

Testing done

Tested that with this change the stack overflow no longer appears and the All view and the maven job page are properly shown

Proposed changelog entries

• Excessive work was being performed when loading builds from disk, which could cause an error when using the Maven and Naginator plugins and the experimental build UI.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[jglick]

Note: in Jira I also proposed a complementary optimization to #11141 by @janfaracik

jenkins/core/src/main/java/jenkins/run/ChangesTabFactory.java

Lines 54 to 61 in c44796d

	if (target instanceof RunWithSCM<?, ?> targetWithSCM) {
	var hasChangeSet = !targetWithSCM.getChangeSets().isEmpty();
	if (hasChangeSet) {
	return Collections.singleton(new ChangesTab(target));
	}
	}
	return Collections.emptySet();

jenkins/core/src/main/java/jenkins/run/ChangesTab.java

Lines 46 to 49 in c44796d

	@Override
	public String getUrlName() {
	return "changes";
	}

which could be done separately if desired.

[MarkEWaite]

I confirmed with interactive testing that this change resolves the stackoverflow exception when using naginator, a Maven job, and the new run UI.

[jglick]

I added a changelog entry, please review.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[A1exKH]

LGTM.