-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Introduce experimental API for adding actions to experimental Run UI #11204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janfaracik
wants to merge
41
commits into
jenkinsci:master
Choose a base branch
from
janfaracik:run-app-bar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,311
−265
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
db697ec
Init
janfaracik 0bfbcfd
Refine JS
janfaracik 6c58d4e
Refine
janfaracik 6bed5ac
Update _buttons.scss
janfaracik 06adfd2
Tidy
janfaracik 7d2921f
Update templates.js
janfaracik 96e2eb8
Update templates.js
janfaracik f93066b
Fix loading of breadcrumbs
janfaracik 35a2f60
Create StopRunAction.java
janfaracik 0c0571e
Merge branch 'master' into run-app-bar
janfaracik b544910
Tidy
janfaracik c07fbd2
Merge branch 'master' into run-app-bar
janfaracik c7af3be
Fix tests
janfaracik f64571c
Push
janfaracik 7d1c235
Merge branch 'master' into run-app-bar
janfaracik 3fea627
Merge branch 'master' into run-app-bar
janfaracik 7b08893
Add Javadoc, tidy
janfaracik d09c8f0
Tidy
janfaracik 9873a7b
Merge branch 'master' into run-app-bar
janfaracik 7c59f80
Fix compilation
janfaracik efc1dd2
Fix javadoc build
timja 7a675f8
Merge branch 'master' into run-app-bar
janfaracik efd2767
Merge branch 'master' into run-app-bar
janfaracik dd5a560
Merge branch 'master' into run-app-bar
timja e6150d5
Merge branch 'run-app-bar' of github.com:janfaracik/jenkins into run-…
timja 1282382
Many fixes
timja 399cbb3
WIP
timja 6de8e03
Fix cancel
timja abc73c5
Fix javadoc
timja f8b82c2
Add more Javadoc
timja 594d3f6
More javadoc
timja 237c303
Fix TODOs
timja 71ee89d
Fix wording
timja 47834a9
Fix checkstyle
timja 522381b
Fix spotbugs
timja 5ffd7d6
Merge branch 'master' into run-app-bar
timja a42ed73
Spotbugs
timja a42f115
Mark API as beta
timja 7d7240d
Merge branch 'master' into run-app-bar
timja e5b3082
Merge branch 'master' into run-app-bar
lemeurherve fccb53f
Merge branch 'master' into run-app-bar
timja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,10 @@ | |
|
|
||
| import edu.umd.cs.findbugs.annotations.CheckForNull; | ||
| import hudson.Functions; | ||
| import jenkins.model.menu.Group; | ||
| import jenkins.model.menu.Semantic; | ||
| import jenkins.model.menu.event.Event; | ||
| import jenkins.model.menu.event.LinkEvent; | ||
|
|
||
| /** | ||
| * Object that contributes additional information, behaviors, and UIs to {@link ModelObject} | ||
|
|
@@ -139,4 +143,42 @@ | |
| * @see Functions#getActionUrl(String, Action) | ||
| */ | ||
| @CheckForNull String getUrlName(); | ||
|
|
||
| /** | ||
| * Returns the group that this item belongs to. | ||
| * The default implementation places the item in the menu group. | ||
| * | ||
| * @return the group of this item | ||
| */ | ||
| default Group getGroup() { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the best way of grouping/ordering items? |
||
| return Group.IN_MENU; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the event associated with this item. | ||
| * By default, this creates a link event pointing to the item's URL name. | ||
| * | ||
| * @return the event representing this item | ||
| */ | ||
| default Event getEvent() { | ||
| return LinkEvent.of(getUrlName()); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the semantic information for this item. | ||
| * | ||
| * @return the semantic associated with this item, or {@code null} if none | ||
| */ | ||
| default Semantic getSemantic() { | ||
| return null; | ||
| } | ||
|
|
||
| /** | ||
| * Indicates whether this item should be visible in a context menu for an {@link Actionable}. | ||
| * | ||
| * @return {@code true} if the item is shown in the context menu, {@code false} otherwise | ||
| */ | ||
| default boolean isVisibleInContextMenu() { | ||
| return true; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be part of
Action? Or into its own interface?