Skip to content

Fix MyViewsProperty condition #11252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 2 commits into from
Oct 31, 2025
Merged

Fix MyViewsProperty condition #11252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df24ef
Fix MyViewsProperty condition
janfaracik Oct 30, 2025
dbf6ef9
Use DoNotUse instead
janfaracik Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/hudson/model/View.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,6 +1250,12 @@ public static View createViewFromXML(String name, InputStream xml) throws IOExce
}
}

// for Jelly
@Restricted(DoNotUse.class)
public boolean isMyViewsProperty() {
return getOwner() instanceof MyViewsProperty;
}

public static class PropertyList extends DescribableList<ViewProperty, ViewPropertyDescriptor> {
private PropertyList(View owner) {
super(owner);
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/resources/hudson/model/View/main.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<j:if test="${!newDashboardPage}">
<j:choose>
<j:when test="${it.owner.class == hudson.model.MyViewsProperty.class}">
<j:when test="${it.isMyViewsProperty()}">
<st:include it="${it.owner.viewsTabBar}" page="viewTabs" />
</j:when>
<j:otherwise>
Expand All @@ -41,7 +41,7 @@

<j:if test="${!newDashboardPage}">
<j:choose>
<j:when test="${it.owner.class == hudson.model.MyViewsProperty.class}">
<j:when test="${it.isMyViewsProperty()}">
<st:include it="${it.owner.viewsTabBar}" page="viewTabs" />
</j:when>
<j:otherwise>
Expand Down
Loading