Update dependency org.jenkins-ci.plugins:junit to v1380#11335
Update dependency org.jenkins-ci.plugins:junit to v1380#11335MarkEWaite merged 2 commits intomasterfrom
Conversation
97433e4 to
6a428c4
Compare
6a428c4 to
5ca5013
Compare
5ca5013 to
24255e4
Compare
Since we are including other plugins that are dependencies of junit, it seems correct to include this plugin that is also a dependency of junit. Testing done: * Confirmed that tests pass that were failing prior to this change Testing to do: * Plugin BOM * Acceptance test harness
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
unless you want to requestion the decision of bumping detached plugins when there is a new release as opposed to a security release - the decision is just that, there is an update so it should be merged so long as all tests pass (are there any?). There was no quality metric in the original decision, nor anything about the ATH or bom builds. (it would make sense to use the bom build to manage these and then only bump the bom but that can give you a chicken and egg for the weeklies)? If there are issues in the decision to merge bump PRs then we should not have them in the context of a single PR - it should be in the context of is this even right, or what else needs to be done to make it safe (if it is not safe). So no there is nothing from me. FTR, CloudBees routinely strips all detached plugins and replaces them with ones of known good quality (including running the ATHs and PCTs). |
|
Same: I do not really agree with the policy of routinely updating detached plugins—I rather think we should be removing detached plugins when the split point is more than a year or two old. But this has no effect on CloudBees CI and I do not have strong feelings either way, and yes any real policy discussion should happen on the list rather than in PR comments. |
MarkEWaite
left a comment
There was a problem hiding this comment.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
This PR contains the following updates:
1361.vfed194a_de34a_->1380.v491ff054cd35Release Notes
jenkinsci/junit-plugin (org.jenkins-ci.plugins:junit)
v1380.v491ff054cd35Compare Source
🚀 New features and improvements
👻 Maintenance
📦 Dependency updates
v1372.vfea_f21efa_b_26Compare Source
🚀 New features and improvements
📦 Dependency updates
v1369.v15da_00283f06Compare Source
🐛 Bug fixes
v1368.v066f524494eeCompare Source
🐛 Bug fixes
v1367.v9ea_a_13875e39Compare Source
🐛 Bug fixes
v1366.v23fd7b_ec4a_74Compare Source
🐛 Bug fixes
📦 Dependency updates
v1363.v2ea_b_461a_1480Compare Source
🚀 New features and improvements
🐛 Bug fixes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.