Fix badge tooltips not appearing in Manage Jenkins and Plugin Manager#25906
Fix badge tooltips not appearing in Manage Jenkins and Plugin Manager#25906yoursanonymous wants to merge 5 commits intojenkinsci:masterfrom
Conversation
|
From the screenshots it looks as if the tooltips are a bit misplaced. |
Thanks for checking the misalignment! |
|
The root cause of the problem is #11254 which set |
|
Thanks for pointing out the root cause. |
|
Your solution is more of a hack. And potentially causes issues in situation where the tooltip should not be shown. |
|
I am closing this as this does not seem to address the issue properly, is too hacky and may introduce problems later |
Fixes #23866
The badge counting tooltips stopped appearing while hovering in the Manage Jenkins UI and in the Manage Plugin page that is also visible in the side panel when enabling the the Manage Jenkins UI.
This happens because the badge
<span>elements no longer receive events.As a result, Tippy.js initializes correctly on the
<span>and$el._tippy.show()works, but hover never triggers the tooltip.Testing done
Tested manually on a Jenkins WAR with this change:
Screenshots taken after confirm expected behavior.
Proposed changelog entries
Fix badge tooltips not appearing in the Plugin Manager and the Manage Jenkins UI by correctly computing tooltip padding and attaching the tooltip instance to the appropriate reference element.
Proposed changelog category
/label bug, web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/core-pr-reviewers
@timja
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.