CLI: Decode stdin using client charset; add tests for description/display name#25921
Closed
shbhmexe wants to merge 4 commits intojenkinsci:masterfrom
Closed
CLI: Decode stdin using client charset; add tests for description/display name#25921shbhmexe wants to merge 4 commits intojenkinsci:masterfrom
shbhmexe wants to merge 4 commits intojenkinsci:masterfrom
Conversation
…play name • SetBuildDescriptionCommand: decode stdin via getClientCharset() • SetBuildDisplayNameCommand: decode stdin via getClientCharset() • GroovyCommand: decode '=' script from stdin using client charset Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Member
There are no new unit tests. |
Member
|
I'll go ahead and close the PR, given the description does not align with the change submitted and the submitter has abandoned the PR. |
Contributor
|
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: declined. You can add the required label by adding a comment with the following text: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deliberately does not yet change the stdin sentinel conventions (SetBuildDescriptionCommand uses
=, SetBuildDisplayNameCommand uses-). That alignment can be a follow‑up change. XML‑based CLI commands (create/update job/view/node) are intentionally untouched; they rely on the XML prolog/BOM for charset detection.Testing done
-Dfile.encodingworks as expected.Proposed changelog entries
set-build-description,set-build-display-name, andgroovy.Proposed changelog category
/label bug
Proposed upgrade guidelines
No action is required for most users. If any scripts relied on the controller’s platform default decoding ignoring the client charset, be aware that stdin is now decoded using the client charset (consistent with CLI output). If needed, set the desired charset on the client JVM via
-Dfile.encoding.Submitter checklist
Desired reviewers
Before the changes are marked as ready-for-merge:
Maintainer checklist
upgrade-guide-neededlabel is set and the Proposed upgrade guidelines section is present.lts-candidate.