Skip to content

[JENKINS-69787] Use (x) icon for dismissing admin monitors#25972

Closed
Jayesh45-master wants to merge 1 commit intojenkinsci:masterfrom
Jayesh45-master:good-frist-issue
Closed

[JENKINS-69787] Use (x) icon for dismissing admin monitors#25972
Jayesh45-master wants to merge 1 commit intojenkinsci:masterfrom
Jayesh45-master:good-frist-issue

Conversation

@Jayesh45-master
Copy link

Fixes #69787

Summary

Replace text-based Dismiss buttons in Administrative Monitor banners with a close (×) icon, aligning the UI with Jenkins design conventions and improving visual consistency.

This change is limited to the web UI and does not alter any backend behavior.


Testing done

  • Built Jenkins from source using:
    mvn -DskipTests clean install
  • Ran Jenkins locally using:
    java -jar war/target/jenkins.war --enable-future-java
  • Triggered multiple Administrative Monitors (e.g. Reverse Proxy warning, Root URL not set, Security warnings).
  • Verified that:
  • The dismiss action is rendered as an (×) icon instead of a text button.
  • Hovering over the icon shows the Dismiss tooltip.
  • The button includes an appropriate aria-label for accessibility.
  • Clicking the icon successfully dismisses the admin monitor banner.

Before

Admin Monitor banners displayed a blue Dismiss text button.

After

Admin Monitor banners display a close (×) icon for dismissing.


Proposed changelog entries

  • Use a close (×) icon instead of a text button for dismissing administrative monitor warnings.

Proposed changelog category

/label web-ui, skip-changelog


Proposed upgrade guidelines

N/A


Submitter checklist

  • The issue is well-described.
  • The change is limited to UI behavior and does not alter functionality.
  • Manual testing performed and documented.
  • No new public APIs introduced.
  • UI changes do not violate CSP rules.
  • No upgrade steps required.

Desired reviewers

@jenkinsci/core-pr-reviewers

@welcome
Copy link

welcome bot commented Dec 21, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Dec 21, 2025
@NotMyFault
Copy link
Member

Duplicate of #25964

@NotMyFault NotMyFault marked this as a duplicate of #25964 Dec 21, 2025
@NotMyFault NotMyFault closed this Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants