[JENKINS-69787] Use (x) icon for dismissing admin monitors#25972
Closed
Jayesh45-master wants to merge 1 commit intojenkinsci:masterfrom
Closed
[JENKINS-69787] Use (x) icon for dismissing admin monitors#25972Jayesh45-master wants to merge 1 commit intojenkinsci:masterfrom
Jayesh45-master wants to merge 1 commit intojenkinsci:masterfrom
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
Member
|
Duplicate of #25964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69787
Summary
Replace text-based Dismiss buttons in Administrative Monitor banners with a close (×) icon, aligning the UI with Jenkins design conventions and improving visual consistency.
This change is limited to the web UI and does not alter any backend behavior.
Testing done
mvn -DskipTests clean install
java -jar war/target/jenkins.war --enable-future-java
aria-labelfor accessibility.Before
Admin Monitor banners displayed a blue Dismiss text button.
After
Admin Monitor banners display a close (×) icon for dismissing.
Proposed changelog entries
Proposed changelog category
/label web-ui, skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/core-pr-reviewers