[JENKINS-69787] Use symbol-x icon for dismiss buttons in admin monitors#25981
Closed
adityasah104 wants to merge 1 commit intojenkinsci:masterfrom
Closed
[JENKINS-69787] Use symbol-x icon for dismiss buttons in admin monitors#25981adityasah104 wants to merge 1 commit intojenkinsci:masterfrom
adityasah104 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Replace symbol-close with symbol-x icon in repeatableDeleteButton to improve UX consistency with standard dismiss patterns.
Contributor
|
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: spam. You can add the required label by adding a comment with the following text: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace symbol-close with symbol-x icon in repeatableDeleteButton to improve UX consistency with standard dismiss patterns.
Fixes #18321
This change updates the dismiss button icon in admin monitors from
symbol-closetosymbol-xto align with standard UI patterns for dismiss/close actions. This addresses JENKINS-69787 and improves visual consistency across the Jenkins UI.Testing done
mvn clean installScreenshots (UI changes only)
Before
See screenshots in JENKINS-69787 showing the
symbol-closeicon.After
This PR changes
symbol-closetosymbol-x, replacing the close icon with an X icon for better UX consistency.Proposed changelog entries
Proposed changelog category
/label rfe,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.