[JENKINS-69787] Use icon-based dismiss buttons in admin monitors#25998
Closed
shivapaliwal wants to merge 1 commit intojenkinsci:masterfrom
Closed
[JENKINS-69787] Use icon-based dismiss buttons in admin monitors#25998shivapaliwal wants to merge 1 commit intojenkinsci:masterfrom
shivapaliwal wants to merge 1 commit intojenkinsci:masterfrom
Conversation
- Created reusable dismissButton.jelly component with symbol-close icon
- Updated 15 admin monitor message files to use icon button instead of text
- Replaced <f:submit value=${%Dismiss}/> with <f:dismissButton/>
- Improved UX consistency with repeatableDeleteButton pattern
- Maintained accessibility with tooltip support
- Preserves form submission behavior and name attributes
The new dismissButton component:
- Uses symbol-close icon for visual consistency
- Includes tooltip with localized 'Dismiss' text
- Supports optional name attribute for form handling
- Applies jenkins-button--tertiary styling
Files updated:
- hudson/node_monitors/MonitorMarkedNodeOffline
- hudson/security/csrf/DefaultCrumbIssuer/ExcludeSessionIdAdministrativeMonitor
- hudson/diagnosis/HudsonHomeDiskUsageMonitor
- hudson/diagnosis/ReverseProxySetupMonitor
- hudson/diagnosis/TooManyJobsButNoView
- hudson/diagnosis/OldDataMonitor
- jenkins/security/apitoken/ApiTokenPropertyEnabledNewLegacyAdministrativeMonitor
- jenkins/security/apitoken/ApiTokenPropertyDisabledDefaultAdministrativeMonitor
- jenkins/security/csrf/CSRFAdministrativeMonitor
- jenkins/security/csp/impl/CspRecommendation
- jenkins/model/BuiltInNodeMigration
- jenkins/diagnostics/SecurityIsOffMonitor
- jenkins/diagnostics/RootUrlNotSetMonitor
- jenkins/diagnostics/ControllerExecutorsNoAgents
- jenkins/diagnostics/ControllerExecutorsAgents
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
NotMyFault
requested changes
Dec 28, 2025
Member
NotMyFault
left a comment
There was a problem hiding this comment.
This is inherently wrong and makes no sense.
I'd recommend trying to understand what the issue is, before submittin a PR.
Author
|
/label rfe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new dismissButton component:
Files updated:
Fixes #
Testing done
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.