Skip to content

[JENKINS-69787] Use icon-based dismiss buttons in admin monitors#25998

Closed
shivapaliwal wants to merge 1 commit intojenkinsci:masterfrom
shivapaliwal:fix/JENKINS-69787-dismiss-button-icon
Closed

[JENKINS-69787] Use icon-based dismiss buttons in admin monitors#25998
shivapaliwal wants to merge 1 commit intojenkinsci:masterfrom
shivapaliwal:fix/JENKINS-69787-dismiss-button-icon

Conversation

@shivapaliwal
Copy link

  • Created reusable dismissButton.jelly component with symbol-close icon
  • Updated 15 admin monitor message files to use icon button instead of text
  • Replaced <f:submit value=${%Dismiss}/> with <f:dismissButton/>
  • Improved UX consistency with repeatableDeleteButton pattern
  • Maintained accessibility with tooltip support
  • Preserves form submission behavior and name attributes

The new dismissButton component:

  • Uses symbol-close icon for visual consistency
  • Includes tooltip with localized 'Dismiss' text
  • Supports optional name attribute for form handling
  • Applies jenkins-button--tertiary styling

Files updated:

  • hudson/node_monitors/MonitorMarkedNodeOffline
  • hudson/security/csrf/DefaultCrumbIssuer/ExcludeSessionIdAdministrativeMonitor
  • hudson/diagnosis/HudsonHomeDiskUsageMonitor
  • hudson/diagnosis/ReverseProxySetupMonitor
  • hudson/diagnosis/TooManyJobsButNoView
  • hudson/diagnosis/OldDataMonitor
  • jenkins/security/apitoken/ApiTokenPropertyEnabledNewLegacyAdministrativeMonitor
  • jenkins/security/apitoken/ApiTokenPropertyDisabledDefaultAdministrativeMonitor
  • jenkins/security/csrf/CSRFAdministrativeMonitor
  • jenkins/security/csp/impl/CspRecommendation
  • jenkins/model/BuiltInNodeMigration
  • jenkins/diagnostics/SecurityIsOffMonitor
  • jenkins/diagnostics/RootUrlNotSetMonitor
  • jenkins/diagnostics/ControllerExecutorsNoAgents
  • jenkins/diagnostics/ControllerExecutorsAgents

Fixes #

Testing done

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

- Created reusable dismissButton.jelly component with symbol-close icon
- Updated 15 admin monitor message files to use icon button instead of text
- Replaced <f:submit value=${%Dismiss}/> with <f:dismissButton/>
- Improved UX consistency with repeatableDeleteButton pattern
- Maintained accessibility with tooltip support
- Preserves form submission behavior and name attributes

The new dismissButton component:
- Uses symbol-close icon for visual consistency
- Includes tooltip with localized 'Dismiss' text
- Supports optional name attribute for form handling
- Applies jenkins-button--tertiary styling

Files updated:
- hudson/node_monitors/MonitorMarkedNodeOffline
- hudson/security/csrf/DefaultCrumbIssuer/ExcludeSessionIdAdministrativeMonitor
- hudson/diagnosis/HudsonHomeDiskUsageMonitor
- hudson/diagnosis/ReverseProxySetupMonitor
- hudson/diagnosis/TooManyJobsButNoView
- hudson/diagnosis/OldDataMonitor
- jenkins/security/apitoken/ApiTokenPropertyEnabledNewLegacyAdministrativeMonitor
- jenkins/security/apitoken/ApiTokenPropertyDisabledDefaultAdministrativeMonitor
- jenkins/security/csrf/CSRFAdministrativeMonitor
- jenkins/security/csp/impl/CspRecommendation
- jenkins/model/BuiltInNodeMigration
- jenkins/diagnostics/SecurityIsOffMonitor
- jenkins/diagnostics/RootUrlNotSetMonitor
- jenkins/diagnostics/ControllerExecutorsNoAgents
- jenkins/diagnostics/ControllerExecutorsAgents
@welcome
Copy link

welcome bot commented Dec 28, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inherently wrong and makes no sense.
I'd recommend trying to understand what the issue is, before submittin a PR.

@NotMyFault NotMyFault closed this Dec 28, 2025
@shivapaliwal
Copy link
Author

/label rfe

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants