Skip to content

Validate 'renovate.json' on PRs#26006

Open
NotMyFault wants to merge 1 commit intojenkinsci:masterfrom
NotMyFault:validate-renovate-cfgg
Open

Validate 'renovate.json' on PRs#26006
NotMyFault wants to merge 1 commit intojenkinsci:masterfrom
NotMyFault:validate-renovate-cfgg

Conversation

@NotMyFault
Copy link
Member

The change proposed adds an action validating renovate.json if a PR is raised modifying the file.

Given the complexity of some of renovate's config options, I'd like to see modifications validated beforehand, possibly preventing bad merges or unexpected outcomes.

Looks like

Screenshot 2025-12-28 at 23 37 44

on a failure in the workflow summary.

Testing done

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Dec 28, 2025
Signed-off-by: Alexander Brandes <mc.cache@web.de>
@NotMyFault NotMyFault force-pushed the validate-renovate-cfgg branch from 5399981 to 49246f0 Compare December 28, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Should not be shown in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant