Skip to content

Fixed agent deletion URL when accessed from subpages#26009

Closed
prathamalwayscomeslast wants to merge 7 commits intojenkinsci:masterfrom
prathamalwayscomeslast:issue-26003
Closed

Fixed agent deletion URL when accessed from subpages#26009
prathamalwayscomeslast wants to merge 7 commits intojenkinsci:masterfrom
prathamalwayscomeslast:issue-26003

Conversation

@prathamalwayscomeslast
Copy link
Contributor

@prathamalwayscomeslast prathamalwayscomeslast commented Dec 29, 2025

Fixes #26003

Testing done

Manually tested agent deletion from subpages. Verified the delete action works correctly with no 404 errors

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Used urlPrefix for delete action so it works correctly

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Dec 29, 2025
@prathamalwayscomeslast
Copy link
Contributor Author

prathamalwayscomeslast commented Jan 15, 2026

@MarkEWaite
I think this change is ready to be integrated

@prathamalwayscomeslast
Copy link
Contributor Author

Taken care of in #26177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent sidepanel delete link uses relative url leading to 404 in actions

2 participants