Add agent-secret endpoint to SlaveComputer#26017
Open
adhamahmad wants to merge 3 commits intojenkinsci:masterfrom
Open
Add agent-secret endpoint to SlaveComputer#26017adhamahmad wants to merge 3 commits intojenkinsci:masterfrom
adhamahmad wants to merge 3 commits intojenkinsci:masterfrom
Conversation
Contributor
Author
|
Usage Example:
|
mawinter69
reviewed
Dec 29, 2025
96d96dd to
05a54bc
Compare
mawinter69
suggested changes
Dec 30, 2025
Contributor
Author
|
@jenkinsci/core-pr-reviewers |
Introduces a new /agent-secret web method in SlaveComputer to expose the agent's JNLP MAC. Adds corresponding tests to verify access control and response correctness for users with and without the required permission.
Added Jenkins.READ permission for 'user-without-connect' in SlaveComputerTest to ensure proper authorization setup during testing.
Ensures the web client logs in as userWithoutConnect before attempting to access the agent-secret endpoint.
97e452b to
8f34278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new /agent-secret web method in SlaveComputer to expose the agent's JNLP MAC. Adds corresponding tests to verify access control and response correctness for users with and without the required permission.
Fixes #16537
Testing done
SlaveComputerTestto cover both cases: successful scenario and unsuccessful scenario, by simulating two users: one with the required permissions and the other without.curlto verify the behavior in both successful and unsuccessful scenarios.Proposed changelog entries
SlaveComputerto obtain the secret required for remote launch of an agent.Proposed changelog category
/label rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.