Skip to content

Redirect PluginWrapper root URL to third-party licenses view#26029

Merged
MarkEWaite merged 9 commits intojenkinsci:masterfrom
somiljain2006:Plugin_license_fix
Jan 31, 2026
Merged

Redirect PluginWrapper root URL to third-party licenses view#26029
MarkEWaite merged 9 commits intojenkinsci:masterfrom
somiljain2006:Plugin_license_fix

Conversation

@somiljain2006
Copy link
Contributor

@somiljain2006 somiljain2006 commented Jan 2, 2026

Fixes ~#16812

Redirect requests to the PluginWrapper root URL (/plugin//wrapper/) to the thirdPartyLicenses view. This fixes a 404 error encountered when clicking the plugin name on the "License and dependency information" page.

Testing done

Ensured all tests still passed.

Screenshots (UI changes only)

Before

Screenshot 2026-01-02 at 11 37 17 AM

After

Screenshot 2026-01-02 at 10 25 19 AM

Proposed changelog entries

Fix a 404 error when clicking plugin names on the “License and dependency information for plugins” page.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set, and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

Desired reviewers

@jenkinsci/core-pr-reviewers, @daniel-beck, @MarkEWaite, @strangelookingnerd

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Jan 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a 404 error encountered when clicking plugin names on the "License and dependency information for plugins" page by redirecting requests to the PluginWrapper root URL to the thirdPartyLicenses view.

Changes:

  • Added an index.jelly redirect file that forwards users from /plugin/<name>/wrapper/ to /plugin/<name>/wrapper/thirdPartyLicenses

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@somiljain2006
Copy link
Contributor Author

@MarkEWaite, I have done the required changes. Can you please review it?

@daniel-beck daniel-beck added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Jan 19, 2026
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected in local testing. What used to be 404 is now redirecting to the page you're likely already on.

/plugin/…/wrapper/uninstall is redirecting here as well, but that seems acceptable.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 29, 2026
@MarkEWaite MarkEWaite merged commit 02c84fa into jenkinsci:master Jan 31, 2026
18 checks passed
@welcome
Copy link

welcome bot commented Jan 31, 2026

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


@somiljain2006 somiljain2006 deleted the Plugin_license_fix branch January 31, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants