Redirect PluginWrapper root URL to third-party licenses view#26029
Redirect PluginWrapper root URL to third-party licenses view#26029MarkEWaite merged 9 commits intojenkinsci:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a 404 error encountered when clicking plugin names on the "License and dependency information for plugins" page by redirecting requests to the PluginWrapper root URL to the thirdPartyLicenses view.
Changes:
- Added an index.jelly redirect file that forwards users from
/plugin/<name>/wrapper/to/plugin/<name>/wrapper/thirdPartyLicenses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@MarkEWaite, I have done the required changes. Can you please review it? |
daniel-beck
left a comment
There was a problem hiding this comment.
Works as expected in local testing. What used to be 404 is now redirecting to the page you're likely already on.
/plugin/…/wrapper/uninstall is redirecting here as well, but that seems acceptable.
MarkEWaite
left a comment
There was a problem hiding this comment.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
|
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
Fixes ~#16812
Redirect requests to the PluginWrapper root URL (/plugin//wrapper/) to the thirdPartyLicenses view. This fixes a 404 error encountered when clicking the plugin name on the "License and dependency information" page.
Testing done
Ensured all tests still passed.
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Fix a 404 error when clicking plugin names on the “License and dependency information for plugins” page.
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set, and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.Desired reviewers
@jenkinsci/core-pr-reviewers, @daniel-beck, @MarkEWaite, @strangelookingnerd